Skip to content

Conversation

@jtuple
Copy link
Contributor

@jtuple jtuple commented May 25, 2012

@ghost ghost assigned jtuple and Vagabond May 25, 2012
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this should also escape quote characters in Arg before wrapping it?

re:replace(Arg, "\"", "\\\\\"", [global, {return, list}]).

@Vagabond
Copy link
Contributor

Vagabond commented Jun 4, 2012

I'd like to see the return values checked more as well. I'd also be nice to add a scenario like the one mentioned over in the riak pull request where you stage an add, down the node, and then do the add.

@ghost ghost assigned jtuple Jun 11, 2012
@jtuple
Copy link
Contributor Author

jtuple commented Jul 20, 2012

The feedback on this test was overlooked and not addressed when staged clustering was merged in awhile back. In any case, I'm merging in side branches of riak_test into master so that I can merge all added test functionality together and ensure everything plays well together -- including features like upgrade support that current exist in a side branch but not mainline. This side branch adds support to running arbitrary riak-admin commands and is therefore useful to merge in as well.

I agree that this test should be improved in the future, and created a new issue to track that: #8

@jtuple jtuple merged commit f4776c0 into master Jul 20, 2012
martinsumner pushed a commit that referenced this pull request Feb 15, 2019
 Add a test for `node_confirms` as put option
hmmr pushed a commit to TI-Tokyo/openriak-prefork-riak_test that referenced this pull request Jan 16, 2025
basho#4)

* Add test for reaping tombs, and reflecting API changes associated with  change

* Extend test to cover protocols and failure

And add to group

* Must have tictacaae enabled

But exchange tick set so that it will never run

* Update nextgenrepl_reaptombs.erl

Remove rogue config item

* Update to test with bucket types

* Remove rogue whitespace

ProtocolVersionError was not matching due to rogue white space

* Update nextgenrepl_reaptombs.erl

* Update rebar.config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants