Ranch update and link to official repositroy

[Licenser]

Riak Core links to a rather outdated version of rance that is kept in a basho repository.

For once ranch is a very well behaved library when it comes to tagging versions so it is quite possible to link to the extend repository seems like the 'cleaner' version then forking it.

There are quite some changes ( ninenines/ranch@basho:0.4.0-p1...0.8.4 ) and having a one your old version is quite hard on applications using riak_core and ranch since all will blow up around it the old ranch version.

I've tried running the tests and it reports all of them OK, I could not run dialyzer since make dialyzer does not work out of the box (something about protobufs not compiled with debug info.

Cheers,
Heinz

[slfritchie]

Time for some belated repo curating ... @jaredmorrow Do you have any opinion about this? @metadave Hrm, 'git blame' says that you were the last person to make edits on the lines that call the ranch module (riak_core_service_manager.erl).

[bookshelfdave]

Hello @Licenser -

Ranch is used internally in Riak Enterprise and at this point, we are tied to 0.4.0-p1. We plan to upgrade this dependency, but that won't happen until after Riak 2.0 is released.

Cheers -
Dave

[slfritchie]

New milestone: 2.1

[bookshelfdave]

ranch has been removed as a riak_core dep as of: #480

[jrwest]

Leaving on milestone 2.1

[JeetKunDoug]

Not having reviewed the whole PR, but wondering why we still have an "Update Ranch Version" PR if Ranch isn't in riak_core any more. Can we close this, or is it still needed for something else?

[jonmeredith]

It's definitely used by repl, and probably riak_api.

On Fri, Oct 17, 2014 at 11:42 AM, Doug Rohrer [email protected]
wrote:

Not having reviewed the whole PR, but wondering why we still have an
"Update Ranch Version" PR if Ranch isn't in riak_core any more. Can we
close this, or is it still needed for something else?

—
Reply to this email directly or view it on GitHub
#344 (comment).

Jon Meredith
Chief Architect
Basho Technologies, Inc.
[email protected]

[JeetKunDoug]

True, but it's not used in riak_core, which makes me believe this PR could be closed on riak_core, right?

[Licenser]

I’m fine with closing it just haven’t looked at in the the last year :)

Cheers,
Heinz Nikolaus Gies
[email protected]

On Oct 17, 2014, at 14:50, Doug Rohrer [email protected] wrote:

True, but it's not used in riak_core, which makes me believe this PR could be closed on riak_core, right?

—
Reply to this email directly or view it on GitHub #344 (comment).