Issue65 and some cleanup #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 27, 2015 10:03
…ecode as requested.
…oved unnecessary auto loader in favor of composer. Commented out search test, since I still have no idea wtf is up. Will investigate later if someone reports an issue. Added test to run that was missing.
| @@ -63,7 +67,9 @@ public function getName() | |||
| * Returns the buckets R-value If it is set, | |||
| * otherwise return the R-value for the client. | |||
| * | |||
| * @return integer | |||
| * @param null $r | |||
There was a problem hiding this comment.
@christophermancini shouldn't this be type|null ?
|
@marcodebortoli Does that look better? |
| @@ -208,13 +202,13 @@ public function newBinary($key = null, $data, $content_type = 'application/json' | |||
| * | |||
| * @param string $key - Name of the key. | |||
| * @param int $r - R-Value of the request (defaults to bucket's R) | |||
| * | |||
| * @return Object | |||
| */ | |||
| public function get($key, $r = null) | |||
There was a problem hiding this comment.
I think you don't need the parameter $r anymore here
There was a problem hiding this comment.
Well, it still allows you to pass it through to the reload method to override the bucket - client values for that call. If I remove it, you wouldn't be able to do that from get().
There was a problem hiding this comment.
Oh sorry my bad. I overlooked the reload method
christophermancini
added a commit
that referenced
this pull request
Jun 10, 2015
Issue65 and some cleanup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for removing the urldecode as requested in Issue #65 (CLIENTS-90). I also did some cleanup while I was in there.