Misc improvements #102
Merged
Misc improvements #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…urity tests to match client tools configuration.
…testing, add coverage info to phpunit run, open up phpunit run to all tests, add php7 to list of php releases to test against ignoring any failures for it, add composer self-update.
…ak 2 to simplify the vector clock.
Obsolete client id code.
…for testing purposes
| @@ -68,7 +68,7 @@ public function testPasswordAuth() | |||
| (new Riak\Node\Builder()) | |||
| ->atHost(static::TEST_NODE_HOST) | |||
| ->onPort(static::TEST_NODE_SECURE_PORT) | |||
| ->usingPasswordAuthentication('passuser', 'Test1234') | |||
| ->usingPasswordAuthentication('riakpass', 'Test1234') | |||
There was a problem hiding this comment.
Wasn't able to test this, but should be fine
|
Tests pass. Generally looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove obsolete clientID stuff. Fix support link in composer. Comment out tombstone check due to delete_immediate = 1 setting for testing. Improved testing for CRDTs with context. Added gitattributes file.