Mv bucket expiry2 #235

matthewvon · 2017-01-10T20:15:23Z

No description provided.

…e on nif unload.

thumbot · 2017-01-11T21:16:08Z


mv-bucket-expiry2 `46c20c4`	➡️	develop `b593a41`	✅ completed

Looks good! 👍

✅ MERGE

Started at: 2017-01-11 13:16
Duration: 1 seconds.
Result: OK
Message: Merge Success: mv-bucket-expiry2 46c20c4 onto target branch: develop b593a41
Exit Code: OK

📄







  Auto-merging c_src/eleveldb.cc
Merge made by the 'recursive' strategy.
 c_src/atoms.h     |  37 ++++++++++-
 c_src/eleveldb.cc |  71 ++++++++++++++++-----
 c_src/router.cc   | 181 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
 c_src/router.h    |  45 ++++++++++++++
 src/eleveldb.erl  |  32 +++++++++-
 5 files changed, 346 insertions(+), 20 deletions(-)
 create mode 100644 c_src/router.cc
 create mode 100644 c_src/router.h

…ow works

…id from ERL_NIF_TERM

… io:format() calls, create catch-all

…-bucket-expiry2

thumbot · 2017-01-19T19:43:39Z


mv-bucket-expiry2 `4dc6a6e`	➡️	develop `b593a41`	✅ completed

Looks good! 👍

✅ MERGE

Started at: 2017-01-19 11:43
Duration: 1 seconds.
Result: OK
Message: Merge Success: mv-bucket-expiry2 4dc6a6e onto target branch: develop b593a41
Exit Code: OK

📄







  Auto-merging c_src/eleveldb.cc
Merge made by the 'recursive' strategy.
 c_src/atoms.h       |  37 ++++++++++-
 c_src/build_deps.sh |   2 +-
 c_src/eleveldb.cc   |  75 ++++++++++++++++-----
 c_src/refobjects.cc |   1 -
 c_src/router.cc     | 185 ++++++++++++++++++++++++++++++++++++++++++++++++++++
 c_src/router.h      |  45 +++++++++++++
 src/eleveldb.erl    |  26 +++++++-
 7 files changed, 348 insertions(+), 23 deletions(-)
 create mode 100644 c_src/router.cc
 create mode 100644 c_src/router.h

thumbot · 2017-01-19T22:44:36Z


mv-bucket-expiry2 `eceaa42`	➡️	develop `b593a41`	✅ completed

Looks good! 👍

✅ MERGE

Started at: 2017-01-19 14:44
Duration: 1 seconds.
Result: OK
Message: Merge Success: mv-bucket-expiry2 eceaa42 onto target branch: develop b593a41
Exit Code: OK

📄







  Auto-merging c_src/eleveldb.cc
Merge made by the 'recursive' strategy.
 c_src/atoms.h       |  37 ++++++++++-
 c_src/build_deps.sh |   2 +-
 c_src/eleveldb.cc   |  75 ++++++++++++++++-----
 c_src/refobjects.cc |   1 -
 c_src/router.cc     | 185 ++++++++++++++++++++++++++++++++++++++++++++++++++++
 c_src/router.h      |  45 +++++++++++++
 src/eleveldb.erl    |  26 +++++++-
 7 files changed, 348 insertions(+), 23 deletions(-)
 create mode 100644 c_src/router.cc
 create mode 100644 c_src/router.h

thumbot · 2017-01-20T20:17:19Z


mv-bucket-expiry2 `b395f42`	➡️	develop `b593a41`	✅ completed

Looks good! 👍

✅ MERGE

Started at: 2017-01-20 12:17
Duration: 1 seconds.
Result: OK
Message: Merge Success: mv-bucket-expiry2 b395f42 onto target branch: develop b593a41
Exit Code: OK

📄







  Auto-merging c_src/eleveldb.cc
Merge made by the 'recursive' strategy.
 c_src/atoms.h        |  37 ++++++++++-
 c_src/build_deps.sh  |   2 +-
 c_src/eleveldb.cc    |  84 ++++++++++++++++++-----
 c_src/refobjects.cc  |   1 -
 c_src/router.cc      | 185 +++++++++++++++++++++++++++++++++++++++++++++++++++
 c_src/router.h       |  45 +++++++++++++
 priv/eleveldb.schema |  16 ++---
 src/eleveldb.erl     |  26 +++++++-
 8 files changed, 365 insertions(+), 31 deletions(-)
 create mode 100644 c_src/router.cc
 create mode 100644 c_src/router.h

…ited atom

thumbot · 2017-01-20T20:46:02Z


mv-bucket-expiry2 `011b8a1`	➡️	develop `b593a41`	✅ completed

Looks good! 👍

✅ MERGE

Started at: 2017-01-20 12:46
Duration: 1 seconds.
Result: OK
Message: Merge Success: mv-bucket-expiry2 011b8a1 onto target branch: develop b593a41
Exit Code: OK

📄







  Auto-merging c_src/eleveldb.cc
Merge made by the 'recursive' strategy.
 c_src/atoms.h                  |  37 ++++++++-
 c_src/build_deps.sh            |   2 +-
 c_src/eleveldb.cc              |  84 +++++++++++++++----
 c_src/refobjects.cc            |   1 -
 c_src/router.cc                | 185 +++++++++++++++++++++++++++++++++++++++++
 c_src/router.h                 |  45 ++++++++++
 priv/eleveldb.schema           |   9 --
 src/eleveldb.erl               |  26 +++++-
 test/eleveldb_schema_tests.erl |   6 +-
 9 files changed, 360 insertions(+), 35 deletions(-)
 create mode 100644 c_src/router.cc
 create mode 100644 c_src/router.h

thumbot · 2017-01-31T23:39:16Z


mv-bucket-expiry2 `c63364d`	➡️	develop `996cb43`	✅ completed

Looks good! 👍

✅ MERGE

Started at: 2017-01-31 15:39
Duration: 0 seconds.
Result: OK
Message: Merge Success: mv-bucket-expiry2 c63364d onto target branch: develop 996cb43
Exit Code: OK

📄







  Auto-merging c_src/eleveldb.cc
Auto-merging c_src/build_deps.sh
Merge made by the 'recursive' strategy.
 c_src/atoms.h                  |  37 +++++++-
 c_src/build_deps.sh            |   2 +-
 c_src/eleveldb.cc              |  84 ++++++++++++++----
 c_src/refobjects.cc            |   1 -
 c_src/router.cc                | 189 +++++++++++++++++++++++++++++++++++++++++
 c_src/router.h                 |  45 ++++++++++
 priv/eleveldb.schema           |   9 --
 src/eleveldb.erl               |  26 +++++-
 test/eleveldb_schema_tests.erl |   6 +-
 9 files changed, 364 insertions(+), 35 deletions(-)
 create mode 100644 c_src/router.cc
 create mode 100644 c_src/router.h

thumbot · 2017-02-01T23:22:34Z


mv-bucket-expiry2 `d1da36b`	➡️	develop `996cb43`	✅ completed

Looks good! 👍

✅ MERGE

Started at: 2017-02-01 15:22
Duration: 1 seconds.
Result: OK
Message: Merge Success: mv-bucket-expiry2 d1da36b onto target branch: develop 996cb43
Exit Code: OK

📄







  Auto-merging c_src/eleveldb.cc
Auto-merging c_src/build_deps.sh
Merge made by the 'recursive' strategy.
 c_src/atoms.h                  |  40 ++++++++-
 c_src/build_deps.sh            |   2 +-
 c_src/eleveldb.cc              |  84 ++++++++++++++----
 c_src/refobjects.cc            |   1 -
 c_src/router.cc                | 189 +++++++++++++++++++++++++++++++++++++++++
 c_src/router.h                 |  45 ++++++++++
 priv/eleveldb.schema           |   9 --
 src/eleveldb.erl               |  26 +++++-
 test/eleveldb_schema_tests.erl |   6 +-
 9 files changed, 366 insertions(+), 36 deletions(-)
 create mode 100644 c_src/router.cc
 create mode 100644 c_src/router.h

thumbot · 2017-02-02T16:38:48Z


mv-bucket-expiry2 `0779af7`	➡️	develop `254cba3`	✅ completed

Looks good! 👍

✅ MERGE

Started at: 2017-02-02 08:38
Duration: 1 seconds.
Result: OK
Message: Merge Success: mv-bucket-expiry2 0779af7 onto target branch: develop 254cba3
Exit Code: OK

📄







  Auto-merging c_src/eleveldb.cc
Auto-merging c_src/build_deps.sh
Merge made by the 'recursive' strategy.
 c_src/atoms.h                  |  40 ++++++++-
 c_src/build_deps.sh            |   2 +-
 c_src/eleveldb.cc              |  84 ++++++++++++++----
 c_src/refobjects.cc            |   1 -
 c_src/router.cc                | 189 +++++++++++++++++++++++++++++++++++++++++
 c_src/router.h                 |  45 ++++++++++
 priv/eleveldb.schema           |   9 --
 src/eleveldb.erl               |   8 +-
 src/eleveldb_app.erl           |  37 ++++++++
 src/eleveldb_metadata.erl      | 105 +++++++++++++++++++++++
 src/eleveldb_sup.erl           |  39 +++++++++
 test/eleveldb_schema_tests.erl |   6 +-
 12 files changed, 529 insertions(+), 36 deletions(-)
 create mode 100644 c_src/router.cc
 create mode 100644 c_src/router.h
 create mode 100644 src/eleveldb_app.erl
 create mode 100644 src/eleveldb_metadata.erl
 create mode 100644 src/eleveldb_sup.erl

thumbot · 2017-02-02T17:26:58Z


mv-bucket-expiry2 `fcd3622`	➡️	develop `254cba3`	✅ completed

Looks good! 👍

✅ MERGE

Started at: 2017-02-02 09:26
Duration: 1 seconds.
Result: OK
Message: Merge Success: mv-bucket-expiry2 fcd3622 onto target branch: develop 254cba3
Exit Code: OK

📄







  Auto-merging c_src/eleveldb.cc
Auto-merging c_src/build_deps.sh
Merge made by the 'recursive' strategy.
 c_src/atoms.h                  |  40 ++++++++-
 c_src/build_deps.sh            |   2 +-
 c_src/eleveldb.cc              |  84 ++++++++++++++----
 c_src/refobjects.cc            |   1 -
 c_src/router.cc                | 189 +++++++++++++++++++++++++++++++++++++++++
 c_src/router.h                 |  45 ++++++++++
 priv/eleveldb.schema           |   9 --
 src/eleveldb.app.src           |   3 +-
 src/eleveldb.erl               |   8 +-
 src/eleveldb_app.erl           |  37 ++++++++
 src/eleveldb_metadata.erl      | 105 +++++++++++++++++++++++
 src/eleveldb_sup.erl           |  37 ++++++++
 test/eleveldb_schema_tests.erl |   6 +-
 13 files changed, 529 insertions(+), 37 deletions(-)
 create mode 100644 c_src/router.cc
 create mode 100644 c_src/router.h
 create mode 100644 src/eleveldb_app.erl
 create mode 100644 src/eleveldb_metadata.erl
 create mode 100644 src/eleveldb_sup.erl

…of onload() parameters.

thumbot · 2017-02-02T18:55:27Z


mv-bucket-expiry2 `ab51dc6`	➡️	develop `254cba3`	✅ completed

Looks good! 👍

✅ MERGE

Started at: 2017-02-02 10:55
Duration: 1 seconds.
Result: OK
Message: Merge Success: mv-bucket-expiry2 ab51dc6 onto target branch: develop 254cba3
Exit Code: OK

📄







  Auto-merging c_src/eleveldb.cc
Auto-merging c_src/build_deps.sh
Merge made by the 'recursive' strategy.
 c_src/atoms.h                  |  40 +++++++-
 c_src/build_deps.sh            |   2 +-
 c_src/eleveldb.cc              |  67 ++++++++++---
 c_src/refobjects.cc            |   1 -
 c_src/router.cc                | 209 +++++++++++++++++++++++++++++++++++++++++
 c_src/router.h                 |  45 +++++++++
 priv/eleveldb.schema           |   9 --
 src/eleveldb.app.src           |   3 +-
 src/eleveldb.erl               |  11 ++-
 src/eleveldb_app.erl           |  37 ++++++++
 src/eleveldb_metadata.erl      | 105 +++++++++++++++++++++
 src/eleveldb_sup.erl           |  37 ++++++++
 test/eleveldb_schema_tests.erl |   6 +-
 13 files changed, 538 insertions(+), 34 deletions(-)
 create mode 100644 c_src/router.cc
 create mode 100644 c_src/router.h
 create mode 100644 src/eleveldb_app.erl
 create mode 100644 src/eleveldb_metadata.erl
 create mode 100644 src/eleveldb_sup.erl

…lbacks (there is another one on the horizon

thumbot · 2017-03-03T20:40:12Z


mv-bucket-expiry2 `889d7ab`	➡️	develop `9099f80`	⛔ completed

There seems to be an issue with build step **merge** ! ☁️

⛔ MERGE

Started at: 2017-03-03 12:40
Duration: seconds.
Result: ERROR
Message: Merge Failed: mv-bucket-expiry2 889d7ab onto target branch: develop 9099f80
Exit Code: ERROR

📄







  #<Git::GitExecuteError: git '--git-dir=/tmp/thumbs/develop.9099f80.mv-bucket-expiry2.889d7ab/.git' '--work-tree=/tmp/thumbs/develop.9099f80.mv-bucket-expiry2.889d7ab' merge '-m' 'merge' '889d7ab2268ee6c509b148ef64f2c0f7afaa6d37'  2>&1:error: Your local changes to the following files would be overwritten by merge:
	c_src/atoms.h
	c_src/build_deps.sh
	c_src/eleveldb.cc
	c_src/refobjects.cc
	priv/eleveldb.schema
	src/eleveldb.erl
	test/eleveldb_schema_tests.erl
Please, commit your changes or stash them before you can merge.
error: The following untracked working tree files would be overwritten by merge:
	c_src/router.cc
	c_src/router.h
	src/eleveldb_metadata.erl
Please move or remove them before you can merge.
Aborting>

…ead of direct member variables.

thumbot · 2017-03-05T16:04:22Z


mv-bucket-expiry2 `199e0ca`	➡️	develop `9099f80`	⛔ completed

There seems to be an issue with build step **merge** ! ☁️

⛔ MERGE

Started at: 2017-03-05 08:04
Duration: seconds.
Result: ERROR
Message: Merge Failed: mv-bucket-expiry2 199e0ca onto target branch: develop 9099f80
Exit Code: ERROR

📄







  #<Git::GitExecuteError: git '--git-dir=/tmp/thumbs/develop.9099f80.mv-bucket-expiry2.199e0ca/.git' '--work-tree=/tmp/thumbs/develop.9099f80.mv-bucket-expiry2.199e0ca' merge '-m' 'merge' '199e0ca9c0e703a27bd9b252374e7d4a20d8abf2'  2>&1:error: Your local changes to the following files would be overwritten by merge:
	c_src/atoms.h
	c_src/build_deps.sh
	c_src/eleveldb.cc
	c_src/refobjects.cc
	priv/eleveldb.schema
	src/eleveldb.erl
	test/eleveldb_schema_tests.erl
Please, commit your changes or stash them before you can merge.
error: The following untracked working tree files would be overwritten by merge:
	c_src/router.cc
	c_src/router.h
	src/eleveldb_metadata.erl
Please move or remove them before you can merge.
Aborting>

…t_metadata_pid

…ache get written to cache correctly.

thumbot · 2017-03-06T20:02:54Z


mv-bucket-expiry2 `8201a3a`	➡️	develop `9099f80`	⛔ completed

There seems to be an issue with build step **merge** ! ☁️

⛔ MERGE

Started at: 2017-03-06 12:02
Duration: seconds.
Result: ERROR
Message: Merge Failed: mv-bucket-expiry2 8201a3a onto target branch: develop 9099f80
Exit Code: ERROR

📄







  #<Git::GitExecuteError: git '--git-dir=/tmp/thumbs/develop.9099f80.mv-bucket-expiry2.8201a3a/.git' '--work-tree=/tmp/thumbs/develop.9099f80.mv-bucket-expiry2.8201a3a' merge '-m' 'merge' '8201a3aba4d229038c149af37fb6fe4a989b3c9b'  2>&1:error: Your local changes to the following files would be overwritten by merge:
	c_src/atoms.h
	c_src/build_deps.sh
	c_src/eleveldb.cc
	c_src/refobjects.cc
	priv/eleveldb.schema
	src/eleveldb.erl
	test/eleveldb_schema_tests.erl
Please, commit your changes or stash them before you can merge.
error: The following untracked working tree files would be overwritten by merge:
	c_src/router.cc
	c_src/router.h
	src/eleveldb_metadata.erl
	test/bucket_expiry.erl
Please move or remove them before you can merge.
Aborting>

erikleitch · 2017-03-06T22:28:58Z

(I thought @tburghart was reviewing this one, but the riak team said this morning that I should look at it too, so I'm adding a few notes here, despite not being sure whether this is ready for review, etc)

eleveldb_metadata.erl Is there a deep reason why
eleveldb:property_cache() is separately called from
eleveldb_metadata.erl (instead of just having riak_core call
eleveldb:property_cache directly)? (Or is it leftover from an
earlier architecture that has now changed?)
In router.cc, is there a reason not to return an error atom (or
message) if any of add_metadata_pid, remove_metadata_pid, or
property_cache is called incorrectly? (currently, the code
returns ATOM_OK for a number of these, whether or not there's an
error).

(Looks like these are in process of changing, so maybe this comment
will become irrelevant)
router.cc uses a global service callback object
(gBucketPropCallback) to maintain the erlang pid to contact for
bucket props. This is used both from leveldb to request bucket prop
info (via leveldb_callback) and from erlang to add/remove the pid
(via set_metadata_pid/remove_metadata_pid), so simultaneous access
from multiple thread contexts is possible.

Shouldn't this resource be mutex-protected to ensure that the pid
isn't accessed after remove_metadata_pid has been called, or that
ServiceCallback::GetPid returns true after the pid has been set?

thumbot · 2017-03-07T13:14:50Z


mv-bucket-expiry2 `e62c4cc`	➡️	develop `9099f80`	⛔ completed

There seems to be an issue with build step **merge** ! ☁️

⛔ MERGE

Started at: 2017-03-07 05:14
Duration: seconds.
Result: ERROR
Message: Merge Failed: mv-bucket-expiry2 e62c4cc onto target branch: develop 9099f80
Exit Code: ERROR

📄







  #<Git::GitExecuteError: git '--git-dir=/tmp/thumbs/develop.9099f80.mv-bucket-expiry2.e62c4cc/.git' '--work-tree=/tmp/thumbs/develop.9099f80.mv-bucket-expiry2.e62c4cc' merge '-m' 'merge' 'e62c4cc1dfda066f1cde268ef45611c286e015c2'  2>&1:error: Your local changes to the following files would be overwritten by merge:
	c_src/atoms.h
	c_src/build_deps.sh
	c_src/eleveldb.cc
	c_src/refobjects.cc
	priv/eleveldb.schema
	src/eleveldb.erl
	test/eleveldb_schema_tests.erl
Please, commit your changes or stash them before you can merge.
error: The following untracked working tree files would be overwritten by merge:
	c_src/router.cc
	c_src/router.h
	src/eleveldb_metadata.erl
	test/bucket_expiry.erl
Please move or remove them before you can merge.
Aborting>

macintux · 2017-03-07T13:50:02Z

Good questions Erik.

I think it makes sense to have a translation function between the riak_core callback data and what the NIF expects. The former was designed to be general-purpose.
eleveldb_metadata in general is a relic of an earlier architecture, so we could move that translation function into eleveldb proper, although for the moment I'd like to leave it so we don't have to yet again touch the riak_core PR.
The NIFs need to return ok if, and only if, riak_core should continue servicing eleveldb metadata queries. The riak_core info service code shuts down the service process if any other return value is received. So, if there is an error that means that leveldb can't use the info service, then return an error.

macintux · 2017-03-07T14:10:09Z

Ideally I think we'd allow eleveldb to report two categories of errors: permanent and transient. Future enhancement to the info service, perhaps.

matthewvon · 2017-03-07T15:27:18Z

Added locking around ServiceCallback accessors per code review.

…f blanket ok, per John D.

thumbot · 2017-03-07T18:51:13Z


mv-bucket-expiry2 `9413ecc`	➡️	develop `9099f80`	⛔ completed

There seems to be an issue with build step **merge** ! ☁️

⛔ MERGE

Started at: 2017-03-07 10:51
Duration: seconds.
Result: ERROR
Message: Merge Failed: mv-bucket-expiry2 9413ecc onto target branch: develop 9099f80
Exit Code: ERROR

📄







  #<Git::GitExecuteError: git '--git-dir=/tmp/thumbs/develop.9099f80.mv-bucket-expiry2.9413ecc/.git' '--work-tree=/tmp/thumbs/develop.9099f80.mv-bucket-expiry2.9413ecc' merge '-m' 'merge' '9413eccfaf72802605c4a30146e2b886e8cb281f'  2>&1:error: Your local changes to the following files would be overwritten by merge:
	c_src/atoms.h
	c_src/build_deps.sh
	c_src/eleveldb.cc
	c_src/refobjects.cc
	priv/eleveldb.schema
	src/eleveldb.erl
	test/eleveldb_schema_tests.erl
Please, commit your changes or stash them before you can merge.
error: The following untracked working tree files would be overwritten by merge:
	c_src/router.cc
	c_src/router.h
	src/eleveldb_metadata.erl
	test/bucket_expiry.erl
Please move or remove them before you can merge.
Aborting>

thumbot · 2017-03-07T19:38:33Z


mv-bucket-expiry2 `a15ef55`	➡️	develop `9099f80`	⛔ completed

There seems to be an issue with build step **merge** ! ☁️

⛔ MERGE

Started at: 2017-03-07 11:38
Duration: seconds.
Result: ERROR
Message: Merge Failed: mv-bucket-expiry2 a15ef55 onto target branch: develop 9099f80
Exit Code: ERROR

📄







  #<Git::GitExecuteError: git '--git-dir=/tmp/thumbs/develop.9099f80.mv-bucket-expiry2.a15ef55/.git' '--work-tree=/tmp/thumbs/develop.9099f80.mv-bucket-expiry2.a15ef55' merge '-m' 'merge' 'a15ef556e3693ebcac930b15f7c75329ebd08754'  2>&1:error: Your local changes to the following files would be overwritten by merge:
	c_src/atoms.h
	c_src/build_deps.sh
	c_src/eleveldb.cc
	c_src/refobjects.cc
	priv/eleveldb.schema
	src/eleveldb.erl
	test/eleveldb_schema_tests.erl
Please, commit your changes or stash them before you can merge.
error: The following untracked working tree files would be overwritten by merge:
	c_src/router.cc
	c_src/router.h
	src/eleveldb_metadata.erl
	test/bucket_expiry.erl
Please move or remove them before you can merge.
Aborting>

erikleitch

Oops - I think the spec for eleveldb:property_cache/2 is now wrong (eleveldb::property_cache changed to return ok, or {error, any()}, but spec still reads: -spec property_cache(string(), string()) -> ok.)

matthewvon · 2017-03-08T00:48:20Z

Wrong, maybe. In flux, absolutely. Waiting on API lock down.

… FOR PRODUCTION.

thumbot · 2017-03-12T21:06:18Z


mv-bucket-expiry2 `da8729e`	➡️	develop `9099f80`	⛔ completed

There seems to be an issue with build step **merge** ! ☁️

⛔ MERGE

Started at: 2017-03-12 14:06
Duration: seconds.
Result: ERROR
Message: Merge Failed: mv-bucket-expiry2 da8729e onto target branch: develop 9099f80
Exit Code: ERROR

📄







  #<Git::GitExecuteError: git '--git-dir=/tmp/thumbs/develop.9099f80.mv-bucket-expiry2.da8729e/.git' '--work-tree=/tmp/thumbs/develop.9099f80.mv-bucket-expiry2.da8729e' merge '-m' 'merge' 'da8729e2ee0f51fff6a3968aec4a70741dfa5223'  2>&1:error: Your local changes to the following files would be overwritten by merge:
	c_src/atoms.h
	c_src/build_deps.sh
	c_src/eleveldb.cc
	c_src/refobjects.cc
	priv/eleveldb.schema
	src/eleveldb.erl
	test/eleveldb_schema_tests.erl
Please, commit your changes or stash them before you can merge.
error: The following untracked working tree files would be overwritten by merge:
	c_src/router.cc
	c_src/router.h
	src/eleveldb_metadata.erl
	test/bucket_expiry.erl
Please move or remove them before you can merge.
Aborting>

matthewvon · 2017-03-16T14:59:57Z

This was a horrible merge. Done by hand directly to develop.

Matthew V added 5 commits December 21, 2016 11:26

stub for erlang message router and property cache interface

40fe884

add erlang message router pid to constructor. issue a shutdown messag…

27cfb9c

…e on nif unload.

update list of atoms from eleveldb.cc

431e343

establish base code for leveldb_callback and property_cache functions.

bb8ad06

finish the property_cache routine now that leveldb_ee unit tested

46c20c4

Matthew V added 6 commits January 12, 2017 17:59

save callback pid as ERL_NIF_TERM instead of ErlNifPid. enif_send() n…

27789a5

…ow works

build type,bucket as tuple, not two call parameters. build callback p…

6398809

…id from ERL_NIF_TERM

use only single parameter for type/bucket calls to get_bucket. remove…

eab01b1

… io:format() calls, create catch-all

removed Debug performance counters from AAE debug

48a17f0

add reference to leveldb branch to help others

c3fa268

Merge branch 'mv-bucket-expiry2' of github.com:basho/eleveldb into mv…

4dc6a6e

…-bucket-expiry2

prop_cache.h moved from leveldb_ee to util to simplify non-EE builds

eceaa42

make unlimited atom active within schema

b395f42

cleanup schema tests for expiry_minutes now properly supporting unlim…

011b8a1

…ited atom

add kExpiryUnlimited setting to parse_expiry_properties

c63364d

add ATOM_UNLIMITED to atoms.h for router.cc use

d1da36b

copy John Daily code from jrd_callback-cleanup branch to this branch.

0779af7

John change to make compatible with Erlang 16

fcd3622

change passing of work pid to use set_metadata_pid() instead of part …

ab51dc6

…of onload() parameters.

tell erlang layer that set_metadata_pid exists with eleveldb.so

1b630e4

add a callback atom to pid messaging to allow reuse with multiple cal…

889d7ab

…lbacks (there is another one on the horizon

erikleitch mentioned this pull request Mar 3, 2017

Mv bucket expiry2 basho/leveldb#219

Merged

update eleveldb code to use new option accessors in ExpiryModule inst…

199e0ca

…ead of direct member variables.

first test runs within bucket_expiry.erl ... quick, save it

3d2a3b6

erikleitch mentioned this pull request Mar 6, 2017

Mv bucket expiry2 basho/leveldb_ee#5

Merged

Matthew V added 3 commits March 6, 2017 14:59

add declarations for test support functions property_cache_get and ge…

ae72109

…t_metadata_pid

add unit test support routines property_cache_get and get_metadata_pid.

97f28c1

add set_verify_prop test to verify that properties past to property_c…

8201a3a

…ache get written to cache correctly.

address race condition concern regarding struct ServiceCallback

e62c4cc

update return values to use new {error, {badarg, string()}} instead o…

9413ecc

…f blanket ok, per John D.

add comment about known failure scenario in current test.

a15ef55

erikleitch approved these changes Mar 7, 2017

View reviewed changes

erikleitch reviewed Mar 7, 2017

View reviewed changes

add property_cache_flush to assist with integration testing. NOT SAFE…

da8729e

… FOR PRODUCTION.

macintux mentioned this pull request Mar 13, 2017

Test for leveldb bucket-level expiry in EE basho/riak_test#1288

Open

matthewvon closed this Mar 16, 2017

martincox deleted the mv-bucket-expiry2 branch January 26, 2022 12:44

Mv bucket expiry2 #235

Mv bucket expiry2 #235

Uh oh!

Conversation

matthewvon commented Jan 10, 2017

Uh oh!

thumbot commented Jan 11, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

thumbot commented Jan 19, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

thumbot commented Jan 19, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

thumbot commented Jan 20, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

thumbot commented Jan 20, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

thumbot commented Jan 31, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

thumbot commented Feb 1, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

thumbot commented Feb 2, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

thumbot commented Feb 2, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

thumbot commented Feb 2, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

thumbot commented Mar 3, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

thumbot commented Mar 5, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

thumbot commented Mar 6, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

erikleitch commented Mar 6, 2017

Uh oh!

thumbot commented Mar 7, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

macintux commented Mar 7, 2017

Uh oh!

macintux commented Mar 7, 2017

Uh oh!

matthewvon commented Mar 7, 2017

Uh oh!

thumbot commented Mar 7, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

thumbot commented Mar 7, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

erikleitch left a comment

Choose a reason for hiding this comment

Uh oh!

matthewvon commented Mar 8, 2017

Uh oh!

thumbot commented Mar 12, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

matthewvon commented Mar 16, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

thumbot commented Jan 11, 2017 •

edited

Loading

thumbot commented Jan 19, 2017 •

edited

Loading

thumbot commented Jan 19, 2017 •

edited

Loading

thumbot commented Jan 20, 2017 •

edited

Loading

thumbot commented Jan 20, 2017 •

edited

Loading

thumbot commented Jan 31, 2017 •

edited

Loading

thumbot commented Feb 1, 2017 •

edited

Loading

thumbot commented Feb 2, 2017 •

edited

Loading

thumbot commented Feb 2, 2017 •

edited

Loading

thumbot commented Feb 2, 2017 •

edited

Loading

thumbot commented Mar 3, 2017 •

edited

Loading

thumbot commented Mar 5, 2017 •

edited

Loading

thumbot commented Mar 6, 2017 •

edited

Loading

thumbot commented Mar 7, 2017 •

edited

Loading

thumbot commented Mar 7, 2017 •

edited

Loading

thumbot commented Mar 7, 2017 •

edited

Loading

thumbot commented Mar 12, 2017 •

edited

Loading