Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(man): Use cat as man pager #909

Merged
merged 2 commits into from
Jul 15, 2023
Merged

Conversation

mikesmithgh
Copy link
Contributor

Hi 馃憢, I ran into an issue when I configured Neovim as my default man pager via export MANPAGER='nvim +Man!'. bash-language-server is resolving commands with man but in my case man does not close because it is using Neovim. This can happen for any command in MANPAGER that doesn't exit. Below are a couple examples with different options:

nvim

man-nvim

less

man-less

cat

man-cat

vim

man-vim

In this PR I am explicitly settings the pager to cat to avoid unexpected formatting.

Please let me know if you have any questions or suggestions. Thanks!

Copy link
Collaborator

@skovhus skovhus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for fixing this!

@skovhus skovhus enabled auto-merge July 15, 2023 19:04
@skovhus skovhus merged commit 697099d into bash-lsp:main Jul 15, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants