fix(dsa): fall back for unsupported odd cuDNN top-k - #19
Merged
Conversation
Keep fused score generation and sparse attention while selecting odd top-k values with PyTorch, avoiding cuDNN Frontend's vector-width assertion for packed CP segments. Co-authored-by: Cursor <cursoragent@cursor.com>
2 tasks
pstefa1707
reviewed
Jul 17, 2026
| topk_scores.masked_fill_(~valid, float("-inf")) | ||
| else: | ||
| topk_scores = None | ||
| return {"indices": topk_indices, "values": topk_scores} |
There was a problem hiding this comment.
This will b v slow if its raw pytorch right? When do we hit this case?
Should we have a triton kernel to cover it?
jerryhong21
pushed a commit
that referenced
this pull request
Aug 20, 2026
Keep fused score generation and sparse attention while selecting odd top-k values with PyTorch, avoiding cuDNN Frontend's vector-width assertion for packed CP segments. Co-authored-by: Cursor <cursoragent@cursor.com>
jerryhong21
pushed a commit
that referenced
this pull request
Aug 20, 2026
Keep fused score generation and sparse attention while selecting odd top-k values with PyTorch, avoiding cuDNN Frontend's vector-width assertion for packed CP segments. Co-authored-by: Cursor <cursoragent@cursor.com>
jerryhong21
pushed a commit
that referenced
this pull request
Aug 21, 2026
Keep fused score generation and sparse attention while selecting odd top-k values with PyTorch, avoiding cuDNN Frontend's vector-width assertion for packed CP segments. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
torch.topkto avoid cuDNN Frontend 1.26.0's vector-width assertionTest plan
[235, 705],top_k=705patched primitive passes on B200