Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow registry username to reference a secret #91

Merged
merged 3 commits into from
Mar 8, 2023

Conversation

kjellberg
Copy link
Contributor

From DigitalOcean docs:

For CI systems that support configuring registry authentication via username and password, use a DigitalOcean API token as both the username and the password. The API token must have read/write privileges to push to your registry.

This PR enables users to configure their registry details with a secret for username, like this:

registry:
  server: registry.digitalocean.com
  username:  
    - SECRET_REGISTRY_TOKEN
  password: 
    - SECRET_REGISTRY_TOKEN

solves #89

@dhh dhh merged commit 32ab79c into basecamp:main Mar 8, 2023
@kjellberg kjellberg deleted the lookup_username branch March 8, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants