Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSH: allow setting config: false to ignore local user ~/.ssh/config #908

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

jeremy
Copy link
Member

@jeremy jeremy commented Aug 13, 2024

Documents the existing config option so it can be set via Kamal config. Allows setting config: false to ignore users' ~/.ssh/config.

@jeremy jeremy requested a review from djmb August 13, 2024 20:08
@igor-alexandrov
Copy link
Contributor

@jeremy are you sure that it exists? I cannot find it, to be honest.

@jeremy
Copy link
Member Author

jeremy commented Sep 30, 2024

You mean the sshkit config option, or ?

@jeremy
Copy link
Member Author

jeremy commented Oct 2, 2024

It eventually lands in Net::SSH.start which passes it to Net::SSH.configuration_for to determine which config files to parse.

Can verify by passing config: /some/other/path.conf and verifying the config is parsed or by enabling/disabling and verifying that default config is/isn't parsed (net-ssh defaults to parsing all of %w[ ~/.ssh/config /etc/ssh_config /etc/ssh/ssh_config ]).

@igor-alexandrov
Copy link
Contributor

@jeremy thanks for the explanation.

@djmb djmb merged commit c10b3fb into main Oct 2, 2024
9 checks passed
@djmb djmb deleted the ignorable-ssh-config branch October 2, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants