Configurable Number of Lines in Healthcheck Log Output #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rience
force-pushed
the
custom-healthcheck-log-lines-count
branch
from
ecd58ed
to
053b9d3
Compare
|
Hi @rience, thank you for the PR! There are some conflicts, if you could resolve them when you have time? Also what do you think about changing the setting name to |
rience
force-pushed
the
custom-healthcheck-log-lines-count
branch
from
053b9d3
to
892cf0e
Compare
|
Hi @djmb, That's rebased and name of setting has changed to |
|
@rience - The tests passed on a re-run. The integration tests are running with docker inside docker inside a GitHub action so we do get the odd random failure. Thanks for the PR! |
|
Sure - one more thing @djmb - I've also added this short description to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I was configuring Kamal for our deployments I was limited by number of lines that (by default) Kamal is printing out when running healthcheck. It is hardcoded to "50" and quite often I was only looking at the bottom of stack trace and could not figure out what has gone wrong.
Container is removed after failed deployment and I couldn't find a way to get these logs from anywhere.
So this PR is adding configurable number of lines for healthcheck.