Add the app's default labels to the traefik container #401
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the same service/destination labels used by the app containers to the traefik containers.
I'm sure there's a better way to do this.
I'm also sure there's a reason why we don't want to do this, in case traefik ends up fronting several app backends at once? I don't know if there's work to support that, but IIRC, there was talk about deploying everything on a single box, which could require traefik supporting multiple backends.
In any case, I'd love to discuss this concept, as we have a need to get log data from traefik tagged with these values. The app containers already have these values, but traefik does not.
The admittedly simple alternative is to just drop this into config/deploy.yml:
and then in each destination config:
test/integration/app_test.rb
is failing, but all other tests are passing. I'm not sure it's not something in my env.