Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Configurable SSH log levels" #400

Merged
merged 1 commit into from
Jul 25, 2023
Merged

Conversation

djmb
Copy link
Collaborator

@djmb djmb commented Jul 25, 2023

SSHKit uses the ssh options as part of the connection cache key and the hash of a Logger is not stable. As a result this is breaking the SSHKit connection pool

Reverts #386

@djmb djmb merged commit a71e167 into main Jul 25, 2023
6 checks passed
@jeremy jeremy deleted the revert-386-ssh-log-levels branch September 6, 2023 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant