Support a --rolling option for traefik reboots #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* main: Removed not needed MRSK.traefik.run command in Traefil reboot Updated README with locking directory name Include service name to lock details Configurable SSH log levels Add registry container output to debug Minor tweaks to hooks section in readme Update README.md Updated README.md to make setup examples consistent Login to the registry proactively before stoping Accessory and Traefik
djmb
requested changes
Jul 19, 2023
lib/mrsk/cli/traefik.rb
Outdated
| execute *MRSK.traefik.run, raise_on_non_zero_exit: false | ||
| end | ||
| end | ||
| end | ||
|
|
||
| method_option :rolling, type: :boolean, default: false |
There was a problem hiding this comment.
We use option which is just an alias for method_option everywhere else - could you update for consistency?
|
Thanks for the review @djmb. Readme updated, and option documented. |
djmb
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rolling restarts allow Traefik configuration changes without downtime with:
mrsk traefik reboot --rolling