Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Labels can be added to Traefik #208

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

tannakartikey
Copy link
Contributor

If we need to configure the Traefik container with labels, we need the option to attach labels to the Traefik container itself.

For example, we need this configure secure dashboard for Traefik as described in Traefik docs:
https://doc.traefik.io/traefik/operations/dashboard/#dashboard-router-rule

@tannakartikey tannakartikey force-pushed the add_labels_to_traefik branch 2 times, most recently from 882d4a8 to 56f4444 Compare April 12, 2023 09:16
@tannakartikey
Copy link
Contributor Author

tannakartikey commented Apr 12, 2023

If you try to set Traefik Dashboard basic auth then it will not work because of the wrong escape for the $ symbol. #144 fixes that.

@dhh dhh merged commit 2d0a7e1 into basecamp:main Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants