Bootstrap: multi-OS Docker install #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jeremy
commented
Apr 10, 2023
•
jeremy
commented
- Limit auto-install to root users; otherwise, give manual install guidance
- Support non-Debian/Ubuntu with the multi-OS get.docker.com installer
- Drop native curl dependency by running it with a small Docker image
- Fix up healthcheck test mocks to reflect actual operations
jeremy
commented
Apr 10, 2023
test/cli/healthcheck_test.rb
Outdated
| assert_match "Health check against /up failed to run: unknown, retrying in 3s...", output | ||
| assert_match "Health check succeeded with 200 OK!", output | ||
| end | ||
| end |
There was a problem hiding this comment.
Reworked tests to demonstrate actual failure output and sequencing.
| SSHKit::Backend::Abstract.any_instance.expects(:execute).with(:docker, :info, raise_on_non_zero_exit: false).returns(false).at_least_once | ||
|
|
||
| assert_raise RuntimeError, "Docker is not running on 1.1.1.1, 1.1.1.3, 1.1.1.4, 1.1.1.2. Install it first: https://docs.docker.com/engine/install/" do | ||
| run_command("bootstrap") |
There was a problem hiding this comment.
New bootstrap output indicates where Docker isn't running and how to install it.
jeremy
changed the title
|
Updated to attempt an auto-install—but for root users only—using the multi-OS install script. It's not foolproof, but it relieves MRSK of trying to drive multiple OS and packaging systems. |
|
Think we need a rebase after the new health check strategy right? |
* Limit auto-install to root users; otherwise, give manual install guidance * Support non-Debian/Ubuntu with the multi-OS get.docker.com installer
* main: Simplify domain language to just "boot" and unscoped config keys Retain a fixed number of containers when pruning Don't assume rolling back in message Check all hosts before rolling back Ensure Traefik service name is consistent Extend traefik delay by 1 second Include traefik access logs Check if we are still getting a 404 Also dump load balancer logs Dump traefik logs when app not booted Fix missing for apt-get Report on container health after failure Fix the integration test healthcheck Allow percentage-based rolling deployments Move `group_limit` & `group_wait` under `boot` Limit rolling deployment to boot operation Allow performing boot & start operations in groups
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.