Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push <image>:latest in addition to <image>:<git-ref> #161

Merged
merged 1 commit into from
Mar 28, 2023

Conversation

tbuehlmann
Copy link
Contributor

@tbuehlmann tbuehlmann commented Mar 27, 2023

1ed4a37 introduced pulling <image>:latest in addition to <image>:<git-ref>:

https://github.com/mrsked/mrsk/blob/cec82ac641056dce1718f4cbdc99edcd8bc97484/lib/mrsk/commands/builder/base.rb#L8-L11

As we're not pushing <image>:latest:

https://github.com/mrsked/mrsk/blob/cec82ac641056dce1718f4cbdc99edcd8bc97484/lib/mrsk/commands/builder/native.rb#L10-L14

… we're getting an error when trying to deploy:

ERROR (SSHKit::Command::Failed): docker exit status: 1
docker stdout: Nothing written
docker stderr: Error response from daemon: manifest for <registry>/<project>/<app>:latest not found: manifest unknown: manifest unknown

So this PR adds pushing <image>:latest.

@tbuehlmann tbuehlmann marked this pull request as ready for review March 27, 2023 11:00
@dhh
Copy link
Member

dhh commented Mar 28, 2023

cc @djmb

@dhh dhh merged commit 4184d32 into basecamp:main Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants