Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove accessory images using tags rather than labels #150

Merged
merged 1 commit into from
Mar 24, 2023
Merged

Remove accessory images using tags rather than labels #150

merged 1 commit into from
Mar 24, 2023

Conversation

jeremy
Copy link
Member

@jeremy jeremy commented Mar 23, 2023

Accessory images are removed with docker image prune and a label filter currently, but accessory images are not labeled like app images, so no images are actually removed.

Fix by removing the tagged image, which prunes untagged parents.

@dhh
Copy link
Member

dhh commented Mar 23, 2023

Some failing tests.

@dhh dhh merged commit 17e7491 into basecamp:main Mar 24, 2023
@dhh dhh deleted the remove-accessory-image branch March 24, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants