Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker in docker to Dockerfile for container dev #118

Merged
merged 6 commits into from
Mar 24, 2023

Conversation

rstarmer
Copy link
Contributor

The Dockerfile for MRSK is fine in it's own way, but it doesn't really give you a docker environment that can actually run mrsk! A Dockerfile is added by this pull request to specifically to support the local docker build commands against the local docker daemon.

The README.md is updated to include instructions for launching via Docker (for those without a local Ruby enviornment), and an alias is provided to share .ssh and the docker socket into the container.

A tweak to the readme is included for those who don't login to remote servers as root to point out the need for this when supporting the "install docker" aspect of a new server configuration.

@rstarmer
Copy link
Contributor Author

I noted that in the latest main branch, that docker build was added to the Dockerfile, which is a better approach than mine. I've removed the un-necessary Dockerfile.dind, and updated the README to include a cleaned up build instruction.

@dhh
Copy link
Member

dhh commented Mar 21, 2023

We should reference the container distributed here via ghcr.io/mrsked/cli rather than having to build your own.

@rstarmer
Copy link
Contributor Author

rstarmer commented Mar 23, 2023

@dhh Updated to point to ghcr.io/mrsked/mrsk which I presume is the git target proposed (there does not seem to be a ghcr.io/mrsked/cli image.

@dhh dhh merged commit 89b4b90 into basecamp:main Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants