fix: GitHub Workflow: Docker Publish #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The workflow was failing with:
```
The workflow is not valid. .github/workflows/docker-publish.yml (Line: 22, Col: 14): Unexpected symbol: '|'. Located at position 12 within expression: github.ref | replace('refs/tags/', '')
```
The `set-output` command is deprecated, so the issue has been fixed by utilising the `github.ref_name` context to retrieve the version tag that triggered the workflow.
> `github.ref_name`: The short ref name of the branch or tag that triggered the workflow run. This value matches the branch or tag name shown on GitHub. For example, `feature-branch-1`.
https://docs.github.com/en/actions/learn-github-actions/contexts
davegudge
commented
Mar 10, 2023
Comment on lines
16
to
18
| - | ||
| name: Checkout | ||
| uses: actions/checkout@v3 |
There was a problem hiding this comment.
According to the docker/build-push-action docs, the "Checkout" step can also be removed from this workflow:
By default, this action [
docker/build-push-action] uses the Git context, so you don't need to use the actions/checkout action to check out the repository as this will be done directly by BuildKit.
Suggested change
| - | |
| name: Checkout | |
| uses: actions/checkout@v3 |
davegudge
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The workflow was failing with:
The
set-outputcommand is deprecated, so the issue has been fixed by utilising thegithub.ref_namecontext to retrieve the version tag that triggered the workflow.