chore(contracts): Remove Contracts #236
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
🟡 Heimdall Review Status
|
Collaborator
|
I prefer the idea of moving this into one of the crates if needed. Will defer to @haardikk21 as I believe he's midway through refactoring the tests |
Contributor
Author
Ah got it, didn't realize that was still in progress. If that's the case yes let's move this into whichever crate uses these contracts so it doesn't clutter the top-level repo structure. I can do that in a new PR if @haardikk21 confirms which crate they should be placed in. |
Contributor
Author
|
I'll move this into an issue so we don't clutter PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As far as I could tell, the
contracts/directory is unused and is a legacy item from the test-utils port.If there's a reason to keep solidity contracts, my suggestion would be to move the contracts into whichever crate would use the compiled artifacts. That way, we keep the top-level repository structure clean. In that case, feel free to close this PR!