feat(CHAIN-548): Update script for SmartEscrow ownership transfer initiation #519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
🟡 Heimdall Review Status
|
leopoldjoy
reviewed
Nov 21, 2025
| @@ -0,0 +1,11 @@ | |||
| OP_COMMIT=d09c836f818c73ae139f60b717654c4e53712743 | |||
Contributor
There was a problem hiding this comment.
Is there any reason that this OP commit is different from the 594bc933a38425f745b46399a3619bcdeb74965d that we've been using?
Contributor
Author
There was a problem hiding this comment.
I used the commit associated with u17 (op-contracts/v5.0.0-rc.2 if I'm not mistaken)
jackchuma
reviewed
Nov 24, 2025
Contributor
jackchuma
left a comment
jackchuma
left a comment
There was a problem hiding this comment.
This looks good to me - I think we just need to confirm if the l1 safe address is what we want to own it now that we have the security council involved
| bun run scripts/genValidationFile.ts --rpc-url $(RPC_URL) \ | ||
| --ledger-id $(LEDGER_ACCOUNT) \ | ||
| --workdir .. --forge-cmd 'forge script --rpc-url $(RPC_URL) \ | ||
| $(SCRIPT_NAME) --sig "sign(address[])" "[$(CB_SIGNER_SAFE_ADDR)]" --sender 0x6CD3850756b7894774Ab715D136F9dD02837De50' --out ../validations/cb-signer.json; |
Contributor
There was a problem hiding this comment.
Can we name the output file coinbase-signer.json ? It'll help with readability in the signer tool
| bun run scripts/genValidationFile.ts --rpc-url $(RPC_URL) \ | ||
| --ledger-id $(LEDGER_ACCOUNT) \ | ||
| --workdir .. --forge-cmd 'forge script --rpc-url $(RPC_URL) \ | ||
| $(SCRIPT_NAME) --sig "sign(address[])" "[$(OP_SIGNER_SAFE_ADDR)]" --sender 0x4d494C5F61b60752D3A10062276a0eFC22596151' --out ../validations/op-signer.json; |
Contributor
There was a problem hiding this comment.
and can the op file name be optimism-signer.json ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the script written in #306 to work with our recent tooling.