Skip to content

refactor(encoding-utils): improve ASN.1 signature encoding #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

refactor(encoding-utils): improve ASN.1 signature encoding #156

wants to merge 1 commit into from

Conversation

@derreklut
Copy link

@derreklut derreklut commented Oct 15, 2025 •
edited
Loading

Summary

  • Add negative number handling with leading zero
  • Implement length validation checks
  • Use variable offset for safer encoding
  • Handle edge cases for zero values
  • Add decoding function for testing"

@derreklut
refactor(encoding-utils): improve ASN.1 signature encoding
dae3552 
- Add negative number handling with leading zero
- Implement length validation checks
- Use variable offset for safer encoding
- Handle edge cases for zero values
- Add decoding function for testing"
@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Oct 15, 2025 •
edited
Loading

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@derreklut @cb-heimdall