Add requireBalance Capability for Spend Permissions #154
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Keys now supports this - ready to merge into SDk
Added
requireBalancecapability support for spend permissions in bothsubscribe()andrequestSpendPermission()functions. This capability enables wallets to verify that users have sufficient balance before creating a spend permission, preventing failed transactions due to insufficient funds.Changes:
requireBalanceoptional parameter toSubscriptionOptionstype (defaults totrue)WalletSignCapabilitiestype withrequireBalanceoption forrequestSpendPermission()subscribe()to include capabilities inwallet_signcall whenrequireBalanceis setrequestSpendPermission()to usewallet_sign(instead ofeth_signTypedData_v4) when capabilities are providedwallet_signresponsesHow did you test your changes?
Added test coverage for:
subscribe()withrequireBalance: true- verifies capabilities are included inwallet_signcallsubscribe()withrequireBalance: false- verifies capabilities are excludedsubscribe()withrequireBalance: undefined- verifies default behavior (capabilities included)requestSpendPermission()with capabilities - verifieswallet_signis used with proper parametersrequestSpendPermission()without capabilities - verifies fallback toeth_signTypedData_v4wallet_signresponsesAll tests pass. CI checks (lint, format, test, typecheck) pass.