Extension not working on macos on 1.88.1

[remixer-dec]

Activating extension ban.spellright failed due to an error:
2024-04-29 01:32:00.927 [error] Error [ERR_REQUIRE_ESM]: require() of ES Module /Users/user/.vscode-oss/extensions/ban.spellright-3.0.124-universal/node_modules/os-locale/index.js from /Users/user/.vscode-oss/extensions/ban.spellright-3.0.124-universal/src/spellright.js not supported.
Instead change the require of index.js in /Users/user/.vscode-oss/extensions/ban.spellright-3.0.124-universal/src/spellright.js to a dynamic import() which is available in all CommonJS modules.

Version: 1.88.1
Release: 24104
Commit: 0d01a72525276e5e3771fe5851b9c83de0de1e2b
Date: 2024-04-13T01:43:30.924Z
Electron: 28.2.8
ElectronBuildId: undefined
Chromium: 120.0.6099.291
Node.js: 18.18.2
V8: 12.0.267.19-electron.0
ОС: Darwin arm64 23.4.0

[remixer-dec]

vscode-spellright/src/spellright.js

Line 16 in d66a383

const osLocale = require('os-locale');

Wrapped it with an import as suggested

let osLocale
import('os-locale')
    .then(module => (osLocale = module))
    .catch(error => console.error('Error during dynamic import:', error));
// haven't tested if it is imported correctly, rollback to a version that supports require imports may be a better solution

and faced another error:

Warning

TypeError: glob is not a function
at loadBinary (/Users/user/.vscode-oss/extensions/ban.spellright-3.0.124-universal/lib/bindings.js:18:21)
at Object. (/Users/user/.vscode-oss/extensions/ban.spellright-3.0.124-universal/lib/bindings.js:44:12)

fixed it by changing

vscode-spellright/lib/bindings.js

Line 12 in d66a383

const glob = require('glob');

vscode-spellright/src/spellright.js

Line 11 in d66a383

const glob = require('glob');

to

const {glob} = require("glob") 

and

vscode-spellright/lib/bindings.js

Line 18 in d66a383

const nodeFiles = glob(path.join(__dirname, `bin/${baseName}*${process.arch}*.node`), { sync: true });

vscode-spellright/src/spellright.js

Line 2050 in d66a383

const dictionaryFiles = glob(path.join(pathName, '.vscode', '*.dict', ''), { sync: true });

to

- glob(
+ glob.sync(

After saving and restarting the editor, the extension seems to be working correctly.
P.S. I suggested a workaround to make it work, it may not be the best way to handle backwards compatibility, but idk what really caused this issue in the first place.

[j-lakeman]

Reproduced on Debian, same VSCodium version.

Probaly related:

• Doesn't seem to work on VSCode 1.88.0 #573
• [Bug] The extension stopped working with VS Code 1.82 #561
• Extension not working properly on VSCode 1.74.0 #536
• No longer working as of VS Code version 1.66.0 #500

Root cause might be #500 (comment)

@bartosz-antosik could you update the binary dependencies, please?

[AVAtarMod]

#577 (comment)

After saving and restarting the editor, the extension seems to be working correctly.

I used this on VSCodium 1.89.1 and this works. Thanks.

OS: Linux (Fedora 39)