composer.json: remove --prefer-lowest #1076
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IMHO it's impractical to expect this package to have to work with the "first release of Laravel for any major release" even when there are already sever more releases: no one is/should stick to that version. See also barryvdh#1074 (review)
9 tasks
|
My thought was that if it's not compatible, we should bump the minor version until it is. Usually won't be a problem, but of 7.3 is not compatible for example, but 7.4, why not just require that version as minimum? (Eg 6.6|7.4|8.0) |
|
@barryvdh That would be possible, but for #1074 (review) I don't even know at which version within Laravel 8 it starts working 🤷♀️ I just can't imagine this prefer-lowest being useful. Try open a bug report with Laravel and reporting a version which is not the latest release on any major version => first thing they say it you've to upgrade. So I guess my question is: what's the real benefit? (I know the general benefit, I realize enough projects use this approach, but doesn't make it necessary to follow it everywhere) |
|
OP from #1074 (comment) found a workaround, so maybe indeed we don't need this (personally I still think prefer lowest doesn't make sense, but it's not urgent) => closing |
6 tasks
mfn
added a commit
to mfn/laravel-ide-helper
that referenced
this pull request
May 3, 2021
IMHO it's impractical to expect this package to have to work with the "first release of Laravel for any major release" even when there are already sever more releases: no one is/should stick to that version. This is a re-submit of barryvdh#1076 See also: - barryvdh#1216 (comment) - barryvdh#1185 (comment)
9 tasks
barryvdh
pushed a commit
that referenced
this pull request
Jun 20, 2021
IMHO it's impractical to expect this package to have to work with the "first release of Laravel for any major release" even when there are already sever more releases: no one is/should stick to that version. This is a re-submit of #1076 See also: - #1216 (comment) - #1185 (comment)
fatihdirikman
added a commit
to fatihdirikman/Laravel-IDE-Helper
that referenced
this pull request
Jan 7, 2022
IMHO it's impractical to expect this package to have to work with the "first release of Laravel for any major release" even when there are already sever more releases: no one is/should stick to that version. This is a re-submit of barryvdh/laravel-ide-helper#1076 See also: - barryvdh/laravel-ide-helper#1216 (comment) - barryvdh/laravel-ide-helper#1185 (comment)
renaforsberg824
added a commit
to renaforsberg824/ide-helper-laravel-developer
that referenced
this pull request
Oct 5, 2022
IMHO it's impractical to expect this package to have to work with the "first release of Laravel for any major release" even when there are already sever more releases: no one is/should stick to that version. This is a re-submit of barryvdh/laravel-ide-helper#1076 See also: - barryvdh/laravel-ide-helper#1216 (comment) - barryvdh/laravel-ide-helper#1185 (comment)
lisadeloach63
added a commit
to lisadeloach63/ide-helper-reso-laravel
that referenced
this pull request
Oct 7, 2022
IMHO it's impractical to expect this package to have to work with the "first release of Laravel for any major release" even when there are already sever more releases: no one is/should stick to that version. This is a re-submit of barryvdh/laravel-ide-helper#1076 See also: - barryvdh/laravel-ide-helper#1216 (comment) - barryvdh/laravel-ide-helper#1185 (comment)
sadafrangian3
pushed a commit
to sadafrangian3/ide-helper-laravel
that referenced
this pull request
Oct 18, 2022
IMHO it's impractical to expect this package to have to work with the "first release of Laravel for any major release" even when there are already sever more releases: no one is/should stick to that version. This is a re-submit of barryvdh/laravel-ide-helper#1076 See also: - barryvdh/laravel-ide-helper#1216 (comment) - barryvdh/laravel-ide-helper#1185 (comment)
smile1130
added a commit
to smile1130/laravel-IDE
that referenced
this pull request
Jun 16, 2023
IMHO it's impractical to expect this package to have to work with the "first release of Laravel for any major release" even when there are already sever more releases: no one is/should stick to that version. This is a re-submit of barryvdh/laravel-ide-helper#1076 See also: - barryvdh/laravel-ide-helper#1216 (comment) - barryvdh/laravel-ide-helper#1185 (comment)
d3v2a
pushed a commit
to d3v2a/laravel-ide-helper
that referenced
this pull request
Feb 16, 2024
IMHO it's impractical to expect this package to have to work with the "first release of Laravel for any major release" even when there are already sever more releases: no one is/should stick to that version. This is a re-submit of barryvdh#1076 See also: - barryvdh#1216 (comment) - barryvdh#1185 (comment)
DevsMasterKing
added a commit
to DevsMasterKing/laravel-ide
that referenced
this pull request
Apr 8, 2025
IMHO it's impractical to expect this package to have to work with the "first release of Laravel for any major release" even when there are already sever more releases: no one is/should stick to that version. This is a re-submit of barryvdh/laravel-ide-helper#1076 See also: - barryvdh/laravel-ide-helper#1216 (comment) - barryvdh/laravel-ide-helper#1185 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
IMHO it's impractical to expect this package to have to work with the
"first release of Laravel for any major release" even when there are
already sever more releases: no one is/should stick to that version.
See also #1074 (review)
Type of change