Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support parsing SuppressWarnings tags in doc block #13

Merged
merged 1 commit into from
Nov 25, 2022

Conversation

EspadaV8
Copy link

@EspadaV8 EspadaV8 commented Nov 3, 2022

This should address is issue in the laravel-ide-helper package that breaks @SuppressWarnings tags in the doc blocks (barryvdh/laravel-ide-helper#666).

@EspadaV8 EspadaV8 force-pushed the suppress-warnings-tag-handler branch from 7e63189 to ad14a96 Compare November 3, 2022 11:08
@EspadaV8 EspadaV8 force-pushed the suppress-warnings-tag-handler branch from ad14a96 to 9a2f0eb Compare November 3, 2022 11:09
@EspadaV8
Copy link
Author

EspadaV8 commented Nov 25, 2022

@barryvdh any chance of getting the workflow approved for the MR?

@barryvdh barryvdh merged commit e5e1727 into barryvdh:master Nov 25, 2022
@EspadaV8 EspadaV8 deleted the suppress-warnings-tag-handler branch November 25, 2022 13:10
@EspadaV8
Copy link
Author

Or just merge it, that works too 😁

Will I need to open another MR on the ide-helpers project to bump the version being pulled in?

Thanks 🙏

@barryvdh
Copy link
Owner

I approved it first and it passed ;)

No once tagged it should update.

@EspadaV8
Copy link
Author

Ah, I didn't get a notification about the checks, but yeah, I can see them.

Thanks again, hopefully barryvdh/laravel-ide-helper#666 can be closed off too, soon 😊

@EspadaV8
Copy link
Author

EspadaV8 commented Mar 7, 2023

@barryvdh any chance that a new version will be tagged? Was hoping that we could close barryvdh/laravel-ide-helper#666

@jameshulse
Copy link

Closes barryvdh/laravel-ide-helper#666

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants