Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qt6 QML minimal support #1101

Open
wants to merge 3 commits into
base: qml
Choose a base branch
from

Conversation

fibur
Copy link

@fibur fibur commented Jan 8, 2025

Changes for QML adaptation.

Note: tested only on Ubuntu 22.04, with Qt 6.5.3

Qml porting
As stated previously, I focused mainly on displaying direct scrcpy output in QML. That being said, I did not adapt every possible function and method, as simply I didn't need them. However below changes are good starting point for future developers, to fully implement QtScrcpy in QML.

Ported OpenGL widget to single QQuickItem allowing to display scrcpy output.

Dialog config parameters are moved to new ScrcpyManager QtQuick singleton. Adapted all parameters to Q_PROPERTY so they can be modified before starting stream - some of them may not be needed anymore.

For now manager accepts only one ScrcpyItem connection at once, but this shouldn't be hard to extend in the future.

Below video of minimal QML application using adapted QtScrcpy (source is attached in this PR too):

simplescreenrecorder-2025-01-06_20.59.21.mp4

Note: depends on #1100

@fibur fibur force-pushed the feat/qt6-qml-minimal-support branch from 89b75b6 to 9e12194 Compare January 8, 2025 13:48
@barry-ran
Copy link
Owner

barry-ran commented Jan 10, 2025

rebase and pr to qml branch

@barry-ran barry-ran force-pushed the qt6 branch 2 times, most recently from 92d9a2f to b691319 Compare January 10, 2025 10:01
@barry-ran barry-ran changed the base branch from qt6 to qml January 10, 2025 15:02
@barry-ran barry-ran deleted the branch barry-ran:qml January 10, 2025 18:36
@barry-ran barry-ran closed this Jan 10, 2025
@barry-ran barry-ran reopened this Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants