Improve tests #1
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1 +/- ##
==========================================
- Coverage 91.80% 90.65% -1.15%
==========================================
Files 1 1
Lines 122 107 -15
==========================================
- Hits 112 97 -15
Misses 5 5
Partials 5 5
Continue to review full report at Codecov.
|
| ) | ||
|
|
||
| func ExampleAnything() { | ||
| func TestExampleAnything(t *testing.T) { |
There was a problem hiding this comment.
This is an example test, so the method is named and implemented so that it shows up as an example in the godoc.
https://pkg.go.dev/github.com/barkimedes/go-deepcopy#pkg-examples
For more info on example tests: https://go.dev/blog/examples
| // 2.14 | ||
| // [Phil Harris Rochester van Jones Mary Livingstone Dennis Day] | ||
| // [Jell-O Grape-Nuts] | ||
| if !DeepEqual(expected, actual) { |
There was a problem hiding this comment.
Changing this would make the example not work anymore, so we can drop this suggestion.
| } | ||
|
|
||
| type Foo struct { | ||
| Foo *Foo | ||
| Bar int | ||
| } | ||
|
|
||
| func ExampleMap() { | ||
| func TestExampleMap(t *testing.T) { |
There was a problem hiding this comment.
Since this example doesn't actually show up in the docs (I got rid of copying map as a public interface), we can rename this one, just take out "Example"
(Make it TestMap)
| @@ -77,19 +71,22 @@ func TestInterface(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| func ExampleAvoidInfiniteLoops() { | |||
| func TestExampleAvoidInfiniteLoops(t *testing.T) { | |||
There was a problem hiding this comment.
Same here, can just make it TestAvoidInfiniteLoops
TestXXXconventiont.Errorfto replace some manual output comparison testsquick.Checktest to automatically test non-pointer copies