-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for BDS B2b and IRNSS L1. And update signal detection to match the actual BDS #657
Conversation
@Narugakuruga Thanks for working on this! Looks like there are some failures on CI - https://github.com/barbeau/gpstest/actions/runs/6624229299/job/18020421843?pr=657:
Could you please take a look? |
My apology 😀. I didn't know coding very much. |
I think it's ready now. |
LGTM, thanks @Narugakuruga! |
Add the ability to properly detect BDS B2b and IRNSS L1.
IRNSS L1 support, see Add support for NavIC L1 signal #653.
Remove the code for "B1-2" signal. I think it's an out-of-date mistake. I have checked every website, paper, press there is no such signal.
Rename B1 and B3 to B1I and B3I to match the official name. (It's uppercase "i", not lowercase “L”)
Maybe this will reduce user's confusion. as there are two B1 band.
And yes B3I is not obsolete. It may be supported by consumer market one day.
And the precise frequency for B2b and E5b appear to be 1207.139970 MHz. But GPSTest already display E5b properly.
So I think it's fine.
[√ ] Acknowledge that you're contributing your code under Apache v2.0 license
[√ ] Apply the
AndroidStyle.xml
style template to your code in Android Studio.