Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for BDS B2b and IRNSS L1. And update signal detection to match the actual BDS #657

Merged
merged 5 commits into from
Oct 27, 2023

Conversation

Narugakuruga
Copy link
Contributor

@Narugakuruga Narugakuruga commented Oct 24, 2023

Add the ability to properly detect BDS B2b and IRNSS L1.

  1. BDS "B2" is rename to "B2b", as B2I signal is marked as obsolete in official press release and due to the fact that they share the same frequency. I highly doubt any civilian device was meant to support B2I. More detail see Add support for Beidou-3 B2b signal #652

Source: http://www.beidou.gov.cn/yw/xwzx/201712/t20171226_11012.html

QQ截图20231024161333

  1. IRNSS L1 support, see Add support for NavIC L1 signal  #653.

  2. Remove the code for "B1-2" signal. I think it's an out-of-date mistake. I have checked every website, paper, press there is no such signal.

  3. Rename B1 and B3 to B1I and B3I to match the official name. (It's uppercase "i", not lowercase “L”)
    Maybe this will reduce user's confusion. as there are two B1 band.
    And yes B3I is not obsolete. It may be supported by consumer market one day.

And the precise frequency for B2b and E5b appear to be 1207.139970 MHz. But GPSTest already display E5b properly.
So I think it's fine.
QQ截图20231024162039

  • [√ ] Acknowledge that you're contributing your code under Apache v2.0 license

  • [√ ] Apply the AndroidStyle.xml style template to your code in Android Studio.

@CLAassistant
Copy link

CLAassistant commented Oct 24, 2023

CLA assistant check
All committers have signed the CLA.

@barbeau
Copy link
Owner

barbeau commented Oct 25, 2023

@Narugakuruga Thanks for working on this! Looks like there are some failures on CI - https://github.com/barbeau/gpstest/actions/runs/6624229299/job/18020421843?pr=657:

e: file:///Users/runner/work/gpstest/gpstest/GPSTest/src/androidTest/java/com/android/gpstest/CarrierFreqUtilsTest.kt:223:9 Unresolved reference: beidouB2
e: file:///Users/runner/work/gpstest/gpstest/GPSTest/src/androidTest/java/com/android/gpstest/CarrierFreqUtilsTest.kt:223:18 Variable expected
e: file:///Users/runner/work/gpstest/gpstest/GPSTest/src/androidTest/java/com/android/gpstest/CarrierFreqUtilsTest.kt:224:9 Unresolved reference: beidouB2
e: file:///Users/runner/work/gpstest/gpstest/GPSTest/src/androidTest/java/com/android/gpstest/CarrierFreqUtilsTest.kt:224:18 Variable expected
e: file:///Users/runner/work/gpstest/gpstest/GPSTest/src/androidTest/java/com/android/gpstest/CarrierFreqUtilsTest.kt:226:59 Unresolved reference: beidouB2
e: file:///Users/runner/work/gpstest/gpstest/GPSTest/src/androidTest/java/com/android/gpstest/CarrierFreqUtilsTest.kt:255:9 Unresolved reference: irnssL5
e: file:///Users/runner/work/gpstest/gpstest/GPSTest/src/androidTest/java/com/android/gpstest/CarrierFreqUtilsTest.kt:255:17 Variable expected
e: file:///Users/runner/work/gpstest/gpstest/GPSTest/src/androidTest/java/com/android/gpstest/CarrierFreqUtilsTest.kt:256:9 Unresolved reference: irnssL5
e: file:///Users/runner/work/gpstest/gpstest/GPSTest/src/androidTest/java/com/android/gpstest/CarrierFreqUtilsTest.kt:256:17 Variable expected
e: file:///Users/runner/work/gpstest/gpstest/GPSTest/src/androidTest/java/com/android/gpstest/CarrierFreqUtilsTest.kt:258:59 Unresolved reference: irnssL5

Could you please take a look?

@Narugakuruga
Copy link
Contributor Author

My apology 😀. I didn't know coding very much.
It should be fine now

@Narugakuruga
Copy link
Contributor Author

Narugakuruga commented Oct 27, 2023

I think it's ready now.
Would like to research how to add BDSBAS support too. But will be another day.

@barbeau
Copy link
Owner

barbeau commented Oct 27, 2023

LGTM, thanks @Narugakuruga!

@barbeau barbeau merged commit 221e46c into barbeau:master Oct 27, 2023
5 checks passed
@Narugakuruga Narugakuruga deleted the BDS-update branch November 27, 2023 23:41
@Narugakuruga
Copy link
Contributor Author

Narugakuruga commented Nov 29, 2023

image
In GPS database, B2 was detected.
The previous code can detect B2b as "B2". At least it did work! So the new code should funtion normally too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants