fix(warehouses): make WarehousesList table rows keyboard-accessible + clean dead .clickable-row CSS [Phase 2g]

[barach6662001-bit]

Phase 2g — WarehousesList AntD table-row keyboard accessibility + dead-CSS cleanup

Closes Finding 2 (medium-risk) and Finding 5 (medium-risk, CSS) from the Phase 2e audit. This PR is different from #629/#633/#636 because the rows are AntD <tr> elements rendered through the onRow callback, not plain <div onClick>s.

Before

onRow={(record) => ({
  onClick: () => navigate(`/warehouses/items?warehouse=${record.id}`)
})}
rowClassName={() => 'clickable-row'}

Mouse-clickable (cursor: pointer + hover bg) but no role, no tabIndex, no onKeyDown, no accessible name. Plus theme/global.css had two .clickable-row rules — a properly-scoped one (.ant-table-tbody > tr.clickable-row) and a redundant global !important duplicate.

After (TSX)

onRow now returns the full a11y bundle; AntD spreads it onto the <tr> directly:

• role="button" (matches FieldCard / OperationsTimeline / UpcomingPanel / FieldStatusCard convention)
• tabIndex={0}
• aria-label="{name}, {location || '—'}, {typeLabel}, {statusLabel}" — mirrors visible cells
• onClick — existing navigate, preserved verbatim
• onKeyDown — Enter / Space + preventDefault on Space; unrelated keys ignored

After (CSS)

New focus-visible block next to the existing scoped rules:

.ant-table-tbody > tr.clickable-row:focus { outline: none; }
.ant-table-tbody > tr.clickable-row:focus-visible {
  outline: 2px solid var(--brand);
  outline-offset: -2px;   /* see note */
}
.ant-table-tbody > tr.clickable-row:focus-visible > td {
  background: var(--brand-muted) !important;
}

Why outline-offset: -2px (deviation from the standard +2px): AntD's table container has overflow: hidden + border-radius. A positive offset gets clipped on the leftmost / outer columns. Insetting the ring keeps it visible on every row. The hover background mirror preserves hover/focus visual parity.

Dead-CSS cleanup: the global .clickable-row { cursor: pointer !important; } rule is removed. Pre-deletion verification: repo-wide rg "'clickable-row'|"clickable-row"" returned exactly one consumer (WarehousesList.tsx) which is fully covered by the scoped rule. A small inline comment in global.css documents the removal so future audits don't re-flag a phantom dead rule.

Why role="button" on a <tr>

This overrides the implicit role="row" in the table accessibility tree. Deliberate trade-off: for a row-as-navigation pattern, "this row is activatable" is more useful to AT users than strict table semantics, and it matches the rest of the codebase. The audit explicitly allows this.

Scope (per request)

In: WarehousesList.tsx, new WarehousesList.test.tsx, theme/global.css (focus-visible add + dead duplicate removal).
Out: NotificationBell, CommandPalette, AppLayout, Sidebar, legacy components/dashboard/*, Card / Surface API. The actions-cell <a onClick> is in the audit's false-positives / out-of-scope set and is not touched ("Do not sweep unrelated table rows"). No new dependencies, no route or API or business-logic changes, no redesign.

Tests (14, new file)

Group	Cases
Render	one row per warehouse; empty list → no warehouse-row buttons
Accessibility	aria-label format with location; em-dash placeholder for empty location; typeGrain in label; inactive status in label; tabIndex=0; .clickable-row className preserved
Activation	click; Enter; Space; Space preventDefault; ignored keys; per-row routing sanity

Validation

• pnpm --filter frontend test → 130 / 130 (14 new + 116 existing)
• npx tsc -b --noEmit → clean
• npx eslint <changed files> → 0 errors (2 pre-existing warnings, unrelated to this PR)
• npx vite build → green (✓ built in 34 s)