Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix custom code comment to not trigger clippy #205

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

frederikrothenberger
Copy link

Having a doc comment in the auto-generated file triggers clippy:

warning: empty line after doc comment
    --> /Users/frederikrothenberger/repos/one-core/target/debug/build/core-server-0e480849ff4b80bc/out/shadow.rs:2287:1
     |
2287 | / /// Below code generated by project custom from by build.rs
2288 | |
     | |_^
2289 |   #[allow(dead_code)] pub const APP_VERSION: Option<&str> = None;
     |                       ----------------------------------- the comment documents this constant
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments
     = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default
     = help: if the empty line is unintentional remove it

Simply changing the comment to be a regular one (with just //) fixes the issue.

@baoyachi baoyachi self-requested a review February 8, 2025 11:08
@baoyachi baoyachi merged commit 3f8e543 into baoyachi:master Feb 10, 2025
2 of 5 checks passed
@baoyachi
Copy link
Owner

@frederikrothenberger Thx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants