Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow missing_docs for deprecated CLAP_VERSION constant #160

Merged
merged 1 commit into from
May 19, 2024
Merged

Allow missing_docs for deprecated CLAP_VERSION constant #160

merged 1 commit into from
May 19, 2024

Conversation

qartik
Copy link
Contributor

@qartik qartik commented May 18, 2024

Without this change, using #![deny(missing_docs)] fails:

error: missing documentation for a constant
   --> /Users/kartik/GH/project/target/debug/build/project-6de82e90c60d85bc/out/shadow.rs:588:1
    |
588 | pub const CLAP_VERSION:&str = shadow_rs::formatcp!(r#"{}
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
note: the lint level is defined here
   --> src/lib.rs:13:9
    |
13  | #![deny(missing_docs)]
    |         ^^^^^^^^^^^^

Another possible change is to remove the deprecated constant itself.

@baoyachi baoyachi merged commit d1b724c into baoyachi:master May 19, 2024
7 of 8 checks passed
@baoyachi
Copy link
Owner

Thx @qartik .New version publised,please use:

shadow-rs = "0.28.0"

@qartik qartik deleted the patch-1 branch May 20, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants