Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul documentation #134

Merged
merged 1 commit into from
May 24, 2023
Merged

Conversation

kleinesfilmroellchen
Copy link
Contributor

This adds documentation to all important public items, reworks the main crate documentation, and vastly improves the documentation generated for build constants.

This adds documentation to all important public items, reworks the main
crate documentation, and vastly improves the documentation generated for
build constants.
@baoyachi baoyachi changed the base branch from master to refactor_doc May 24, 2023 01:10
@baoyachi baoyachi merged commit 5b55c24 into baoyachi:refactor_doc May 24, 2023
@baoyachi
Copy link
Owner

Thx @kleinesfilmroellchen

@kleinesfilmroellchen
Copy link
Contributor Author

Thx @kleinesfilmroellchen

any reason why you didn't merge this PR into the main branch?

@baoyachi
Copy link
Owner

The github action build error in rust nightly. I'll fix ok merge into master branch.

See:https://github.com/baoyachi/shadow-rs/actions/runs/5049364024/jobs/9064716795

@kleinesfilmroellchen
Copy link
Contributor Author

The github action build error in rust nightly. I'll fix ok merge into master branch.

See:https://github.com/baoyachi/shadow-rs/actions/runs/5049364024/jobs/9064716795

Okay; I'm pretty sure I didn't cause that issue though, since I didn't touch any if let code.

@baoyachi baoyachi mentioned this pull request May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants