Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clippy issues in the generated shadow.rs file #151

Closed
szabgab opened this issue Feb 12, 2024 · 2 comments · Fixed by #176
Closed

clippy issues in the generated shadow.rs file #151

szabgab opened this issue Feb 12, 2024 · 2 comments · Fixed by #176

Comments

@szabgab
Copy link

szabgab commented Feb 12, 2024

I have a project with lots of clippy lints enables. Adding shadow-rs I started to get lots of complaints from the out/shadow.rs that, as I understand it, is generated during the build step. Specifically I had to disable these.

[lints.clippy]
non_ascii_literal = "allow"
print_stdout = "allow"
needless_raw_strings = "allow"
needless_raw_string_hashes = "allow"

It would be nice if I could enable them again.

Using shadow-rs version 0.26.1

@dsully
Copy link

dsully commented Apr 6, 2024

+1

@baoyachi
Copy link
Owner

Thank you for your feedback on this issue. Although the issue has been pending for a while, we still appreciate @thecaralice for resolving it.

Please use new publised version:

shadow-rs = "0.33.0"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants