openapi: support nullable attribute with temporary generator image #1747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bonifaido
changed the title
bonifaido
changed the title
bonifaido
force-pushed
the
openapi-nullable
branch
from
f27a03d
to
a9b7439
Compare
baluchicken
approved these changes
Feb 13, 2019
|
FYI: OpenAPITools/openapi-generator#1869 has been merged into master. 😉 |
|
Thanks for the heads up @ackintosh ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
The OpenAPI specification gives support for nullable fields via the nullable attribute but this feature has not landed yet in the official generator CLI, thus I have updated the image built from the PR branch until the feature arrives.
Why?
It's not possible to use pointer fields for example
*time.Timeis not achievable, however null and time.Time = 0 is very different.Additional Context
oneOfwas broken (made no effect on the generated code, it still generatedmap[string]interface{}) previously as well, but now it becomes broken (the hard way) since it references a type calledOneOfAorBorCbut that actual type is not generated (results in compile time error). For the time being, I have commented out the brokenoneOfparts from the API specification.Checklist
make generate-client) (if needed)