Revert k8s-csr PKIbackend for KafkaCluster #972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 27bfa47.
bartam1
approved these changes
May 16, 2023
panyuenlau
approved these changes
May 16, 2023
ctrlaltluc
added a commit
to adobe/koperator
that referenced
this pull request
Jun 8, 2023
…herrypick-from-banzai-master * banzai/master: Add new CruiseControlTaskOperation to represent Status Cruise Control Operation (banzaicloud#975) Use permanent Slack link in README (banzaicloud#985) update cert-manager dependency libraries to 1.11.2 (banzaicloud#981) Adding test cases for kafka user issuerRef group (banzaicloud#967) fix(cc): re-creation of CC metrics topic (banzaicloud#976) Revert "Enabling k8s-csr for PKIbackend in kafka cluster spec (banzaicloud#970)" (banzaicloud#972) Using gomock to mock sigs.k8s.io/controller-runtime/pkg/client If (banzaicloud#973) # Conflicts: # go.mod # go.sum # pkg/resources/kafka/kafka_test.go
panyuenlau
added a commit
that referenced
this pull request
Jun 8, 2023
…#972) This reverts commit 27bfa47. Co-authored-by: Marton Barta <[email protected]> Co-authored-by: Darren Lau <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope: BREAKING CHANGE
Ticket: -
Complexity: trivial
What: Reverted the addition of k8s-csr PKIBackend in KafkaCluster.
Why: We are not aiming to implement support for that right now and this way it is communicated cleaner towards users the implementation for that PKIBackend is not ready.
Notes:
.