Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added KafkaCluster.spec.envoyConfig.PodSecurityContext to the API #956

Merged
merged 1 commit into from
Apr 4, 2023
Merged

Added KafkaCluster.spec.envoyConfig.PodSecurityContext to the API #956

merged 1 commit into from
Apr 4, 2023

Conversation

pregnor
Copy link
Member

@pregnor pregnor commented Apr 3, 2023

Q A
Bug fix? no
New feature? yes
API breaks? no
Deprecations? no
Related tickets -
License Apache 2.0

What's in this PR?

Added KafkaCluster.spec.envoyConfig.PodSecurityContext to the API

Why?

RHOS requires setting some fields which needed propagation.

Checklist

  • Implementation tested
  • Error handling code meets the guideline
  • Logging code meets the guideline
  • User guide and development docs updated (if needed)

@pregnor pregnor added the enhancement New feature or request label Apr 3, 2023
@pregnor pregnor self-assigned this Apr 3, 2023
@pregnor pregnor requested a review from a team as a code owner April 3, 2023 23:12
@pregnor pregnor mentioned this pull request Apr 3, 2023
Merged
3 tasks
bartam1
bartam1 previously approved these changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@bartam1 bartam1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with two suggestion

@pregnor
feat(api,kcl): added envoyCfg.PodSecurityContext
f92ce01 
RHOS requires setting some fields which needed
propagation.
@pregnor pregnor force-pushed the feat/envoy-podsecuritycontext branch from a162c59 to f92ce01 Compare April 4, 2023 09:55
@pregnor pregnor merged commit 78055db into master Apr 4, 2023
@pregnor pregnor deleted the feat/envoy-podsecuritycontext branch April 4, 2023 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kuvesz Kuvesz Kuvesz approved these changes

@bartam1 bartam1 bartam1 approved these changes

Assignees

@pregnor pregnor

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pregnor @Kuvesz @bartam1