Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: propagate context in test suite #950

Merged
merged 1 commit into from
Mar 13, 2023
Merged

refactor: propagate context in test suite #950

merged 1 commit into from
Mar 13, 2023

Conversation

chrisgacsal
Copy link
Contributor

@chrisgacsal chrisgacsal commented Mar 12, 2023 •
edited
Loading

Q A
Bug fix? no
New feature? no
API breaks? no
Deprecations? no
Related tickets -
License Apache 2.0

What's in this PR?

Checklist

  • Implementation tested
  • Error handling code meets the guideline
  • Logging code meets the guideline

To Do

@chrisgacsal chrisgacsal changed the title refactor: propagates context in test suite refactor: propagate context in test suite Mar 12, 2023
@chrisgacsal chrisgacsal marked this pull request as ready for review March 13, 2023 10:13
@chrisgacsal chrisgacsal requested a review from a team as a code owner March 13, 2023 10:13
@chrisgacsal chrisgacsal self-assigned this Mar 13, 2023
pregnor
pregnor previously approved these changes Mar 13, 2023
View reviewed changes
Copy link
Member

@pregnor pregnor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot

@chrisgacsal chrisgacsal requested a review from pregnor March 13, 2023 10:28
panyuenlau
panyuenlau approved these changes Mar 13, 2023
View reviewed changes
Copy link
Member

@panyuenlau panyuenlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thx for cleaning it up

@chrisgacsal chrisgacsal merged commit a29f822 into master Mar 13, 2023
@chrisgacsal chrisgacsal deleted the refactor-tests branch March 13, 2023 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pregnor pregnor pregnor approved these changes

@panyuenlau panyuenlau panyuenlau approved these changes

@bartam1 bartam1 Awaiting requested review from bartam1

Assignees

@chrisgacsal chrisgacsal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chrisgacsal @pregnor @panyuenlau