Update sub-Go-module tags to valid values, remove local replacement #929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously invalid tags were specified for Koperator sub-Go-modules (api, properties), tagged these and referenced the latest tags.
Previously the local sub-Go-modules (api, properties) were depended upon by the root Go module using a local replacement. Removed this because it is not transitive to downstream usage - where Koperator is also a dependency - and is anyway only neede for development purposes which can be kept on local machine instead of having it committed to the repo.
pregnor
changed the title
panyuenlau
approved these changes
Feb 10, 2023
Kuvesz
approved these changes
Feb 10, 2023
bartam1
pushed a commit
that referenced
this pull request
Feb 17, 2023
…929) * chore(go-mod): fixed Koperator submodule tags Previously invalid tags were specified for Koperator sub-Go-modules (api, properties), tagged these and referenced the latest tags. * chore(go-mod): removed local replacements Previously the local sub-Go-modules (api, properties) were depended upon by the root Go module using a local replacement. Removed this because it is not transitive to downstream usage - where Koperator is also a dependency - and is anyway only neede for development purposes which can be kept on local machine instead of having it committed to the repo.
aguzovatii
added a commit
to adobe/koperator
that referenced
this pull request
Mar 28, 2023
As part of banzaicloud#929, the local replacement for sub-modules was removed in favor of using valid tags. Adobe Koperator fork has some internal changes in the api sub-module, so we need to use the local version of the sub-module instead of the upstream version, so we are forced to revert the changes from banzaicloud#929.
5 tasks
aguzovatii
added a commit
to adobe/koperator
that referenced
this pull request
Apr 6, 2023
As part of banzaicloud#929, the local replacement for sub-modules was removed in favor of using valid tags. Adobe Koperator fork has some internal changes in the api sub-module, so we need to use the local version of the sub-module instead of the upstream version, so we are forced to revert the changes from banzaicloud#929.
amuraru
pushed a commit
to adobe/koperator
that referenced
this pull request
May 16, 2023
As part of banzaicloud#929, the local replacement for sub-modules was removed in favor of using valid tags. Adobe Koperator fork has some internal changes in the api sub-module, so we need to use the local version of the sub-module instead of the upstream version, so we are forced to revert the changes from banzaicloud#929.
ctrlaltluc
added a commit
to adobe/koperator
that referenced
this pull request
May 19, 2023
* [INTERNAL] [BUILD] Publish docker images to adobe/kafka-operator and adobe/kafka docker hub repos - build the koperator docker image - build Apache kafka docker image When `kafka-*` tags are created a github action is triggered to build and push a new adobe/kafka docker image version * [INTERNAL] make manifests should be called manually, if needed (#25) We made some chnages for spinnaker annotations and `preserveUnknownFields` that would be overriden by `make manifests` * [INTERNAL] Allow Kafka to use External DNS for inter-broker protocol (#17) (#22) * [INTERNAL] Allow external listeners to be used for inner communication (#26) * [INTERNAL] Ensure external listerners are always the first the advertised.listeners configuration This is needed for old clients connecting to kafka through Zookeeper that does not have a way to infer the right listener. In this case, the first listener in the advertised.listener config is used to connect to brokers. This patch ensures the external listeners (those reachable from outside) are listed before internal ones * [INTERNAL] Generate CRDs resources * [INTERNAL] Upgrade to Kafka 2.8.1 (#36) * Enable envoy idleTimeout and TCP keep-alive for connections to kafka and clients 1/ Kafka broker defines connections.max.idle.ms=600s To ensure envoy as a client for kafka broker is terminating the connection first to avoid network disconnects this patch is setting the idleTimeout to value slightly less than that 2/ Enable tcp-keep alive for all TCP connections established by envoy to kafka and to client (or fronting Load Balancer) * Enable envoy tls termination (#41) * [INTERNAL] Build kafka 3.1.1 using Oracle OpenJDK * Envoy config generated by the operator is invalid in envoy 1.22 Added explicit typeconfig for envoy.filters.http.router ``` [2022-06-16 13:27:58.425][1][info][main] [source/server/server.cc:939] exiting Didn't find a registered implementation for 'envoy.filters.http.router' with type URL: '' ``` * Added TaintedBrokersSelector to kafkaClusterSpec (#48) Co-authored-by: Adrian Muraru <[email protected]> * Build kafka 3.2.2 * Upgrade kafka to 3.2.3 * Upgrade kafka to 3.3.1 * [Internal] Update helm for adobe builds (#52) * [INTERNAL] Use local replacement for sub-modules (#54) As part of banzaicloud#929, the local replacement for sub-modules was removed in favor of using valid tags. Adobe Koperator fork has some internal changes in the api sub-module, so we need to use the local version of the sub-module instead of the upstream version, so we are forced to revert the changes from banzaicloud#929. * Upgrade kafka to 3.4.0 --------- Co-authored-by: Adi Muraru <[email protected]> Co-authored-by: Adrian Lungu <[email protected]> Co-authored-by: Razvan Dobre <[email protected]> Co-authored-by: Adrian Muraru <[email protected]> Co-authored-by: Adrian Coman <[email protected]> Co-authored-by: aguzovatii <[email protected]>
ctrlaltluc
pushed a commit
to adobe/koperator
that referenced
this pull request
Jun 8, 2023
As part of banzaicloud#929, the local replacement for sub-modules was removed in favor of using valid tags. Adobe Koperator fork has some internal changes in the api sub-module, so we need to use the local version of the sub-module instead of the upstream version, so we are forced to revert the changes from banzaicloud#929.
ctrlaltluc
added a commit
to adobe/koperator
that referenced
this pull request
Jun 8, 2023
* [INTERNAL] [BUILD] Publish docker images to adobe/kafka-operator and adobe/kafka docker hub repos - build the koperator docker image - build Apache kafka docker image When `kafka-*` tags are created a github action is triggered to build and push a new adobe/kafka docker image version * [INTERNAL] make manifests should be called manually, if needed (#25) We made some chnages for spinnaker annotations and `preserveUnknownFields` that would be overriden by `make manifests` * [INTERNAL] Allow Kafka to use External DNS for inter-broker protocol (#17) (#22) * [INTERNAL] Allow external listeners to be used for inner communication (#26) * [INTERNAL] Ensure external listerners are always the first the advertised.listeners configuration This is needed for old clients connecting to kafka through Zookeeper that does not have a way to infer the right listener. In this case, the first listener in the advertised.listener config is used to connect to brokers. This patch ensures the external listeners (those reachable from outside) are listed before internal ones * [INTERNAL] Generate CRDs resources * [INTERNAL] Upgrade to Kafka 2.8.1 (#36) * Enable envoy idleTimeout and TCP keep-alive for connections to kafka and clients 1/ Kafka broker defines connections.max.idle.ms=600s To ensure envoy as a client for kafka broker is terminating the connection first to avoid network disconnects this patch is setting the idleTimeout to value slightly less than that 2/ Enable tcp-keep alive for all TCP connections established by envoy to kafka and to client (or fronting Load Balancer) * Enable envoy tls termination (#41) * [INTERNAL] Build kafka 3.1.1 using Oracle OpenJDK * Envoy config generated by the operator is invalid in envoy 1.22 Added explicit typeconfig for envoy.filters.http.router ``` [2022-06-16 13:27:58.425][1][info][main] [source/server/server.cc:939] exiting Didn't find a registered implementation for 'envoy.filters.http.router' with type URL: '' ``` * Added TaintedBrokersSelector to kafkaClusterSpec (#48) Co-authored-by: Adrian Muraru <[email protected]> * Build kafka 3.2.2 * Upgrade kafka to 3.2.3 * Upgrade kafka to 3.3.1 * [Internal] Update helm for adobe builds (#52) * [INTERNAL] Use local replacement for sub-modules (#54) As part of banzaicloud#929, the local replacement for sub-modules was removed in favor of using valid tags. Adobe Koperator fork has some internal changes in the api sub-module, so we need to use the local version of the sub-module instead of the upstream version, so we are forced to revert the changes from banzaicloud#929. * Upgrade kafka to 3.4.0 --------- Co-authored-by: Adi Muraru <[email protected]> Co-authored-by: Adrian Lungu <[email protected]> Co-authored-by: Razvan Dobre <[email protected]> Co-authored-by: Adrian Muraru <[email protected]> Co-authored-by: Adrian Coman <[email protected]> Co-authored-by: aguzovatii <[email protected]>
ctrlaltluc
pushed a commit
to adobe/koperator
that referenced
this pull request
Jun 8, 2023
As part of banzaicloud#929, the local replacement for sub-modules was removed in favor of using valid tags. Adobe Koperator fork has some internal changes in the api sub-module, so we need to use the local version of the sub-module instead of the upstream version, so we are forced to revert the changes from banzaicloud#929.
ctrlaltluc
added a commit
to adobe/koperator
that referenced
this pull request
Jun 8, 2023
* [INTERNAL] [BUILD] Publish docker images to adobe/kafka-operator and adobe/kafka docker hub repos - build the koperator docker image - build Apache kafka docker image When `kafka-*` tags are created a github action is triggered to build and push a new adobe/kafka docker image version * [INTERNAL] make manifests should be called manually, if needed (#25) We made some chnages for spinnaker annotations and `preserveUnknownFields` that would be overriden by `make manifests` * [INTERNAL] Allow Kafka to use External DNS for inter-broker protocol (#17) (#22) * [INTERNAL] Allow external listeners to be used for inner communication (#26) * [INTERNAL] Ensure external listerners are always the first the advertised.listeners configuration This is needed for old clients connecting to kafka through Zookeeper that does not have a way to infer the right listener. In this case, the first listener in the advertised.listener config is used to connect to brokers. This patch ensures the external listeners (those reachable from outside) are listed before internal ones * [INTERNAL] Generate CRDs resources * [INTERNAL] Upgrade to Kafka 2.8.1 (#36) * Enable envoy idleTimeout and TCP keep-alive for connections to kafka and clients 1/ Kafka broker defines connections.max.idle.ms=600s To ensure envoy as a client for kafka broker is terminating the connection first to avoid network disconnects this patch is setting the idleTimeout to value slightly less than that 2/ Enable tcp-keep alive for all TCP connections established by envoy to kafka and to client (or fronting Load Balancer) * Enable envoy tls termination (#41) * [INTERNAL] Build kafka 3.1.1 using Oracle OpenJDK * Envoy config generated by the operator is invalid in envoy 1.22 Added explicit typeconfig for envoy.filters.http.router ``` [2022-06-16 13:27:58.425][1][info][main] [source/server/server.cc:939] exiting Didn't find a registered implementation for 'envoy.filters.http.router' with type URL: '' ``` * Added TaintedBrokersSelector to kafkaClusterSpec (#48) Co-authored-by: Adrian Muraru <[email protected]> * Build kafka 3.2.2 * Upgrade kafka to 3.2.3 * Upgrade kafka to 3.3.1 * [Internal] Update helm for adobe builds (#52) * [INTERNAL] Use local replacement for sub-modules (#54) As part of banzaicloud#929, the local replacement for sub-modules was removed in favor of using valid tags. Adobe Koperator fork has some internal changes in the api sub-module, so we need to use the local version of the sub-module instead of the upstream version, so we are forced to revert the changes from banzaicloud#929. * Upgrade kafka to 3.4.0 --------- Co-authored-by: Adi Muraru <[email protected]> Co-authored-by: Adrian Lungu <[email protected]> Co-authored-by: Razvan Dobre <[email protected]> Co-authored-by: Adrian Muraru <[email protected]> Co-authored-by: Adrian Coman <[email protected]> Co-authored-by: aguzovatii <[email protected]>
amuraru
pushed a commit
to adobe/koperator
that referenced
this pull request
Jun 10, 2023
As part of banzaicloud#929, the local replacement for sub-modules was removed in favor of using valid tags. Adobe Koperator fork has some internal changes in the api sub-module, so we need to use the local version of the sub-module instead of the upstream version, so we are forced to revert the changes from banzaicloud#929.
amuraru
pushed a commit
to adobe/koperator
that referenced
this pull request
Dec 12, 2023
As part of banzaicloud#929, the local replacement for sub-modules was removed in favor of using valid tags. Adobe Koperator fork has some internal changes in the api sub-module, so we need to use the local version of the sub-module instead of the upstream version, so we are forced to revert the changes from banzaicloud#929.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Why?
Additional context
We intend to release a new Koperator version with this change so Koperator can be depended upon, we will immediately pull it into another project as well to test the result.
Checklist
Implementation testedError handling code meets the guidelineLogging code meets the guidelineUser guide and development docs updated (if needed)