Fix Kafka super.users override #923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pregnor
reviewed
Jan 31, 2023
bartam1
force-pushed
the
superuserfix
branch
from
c0d80da to
3cc50f8
Compare
pregnor
previously approved these changes
Feb 13, 2023
panyuenlau
previously approved these changes
Feb 13, 2023
panyuenlau
approved these changes
Feb 15, 2023
pregnor
approved these changes
Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Merges custom super.users configuration with the Koperator auto generated one.
Why?
When there is custom super.users configuration in the KafkaCluster CR and there is SSL listener, Koperator generated super.user configuration overrides the custom one.
Additional context
Checklist