Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Koperator performance test load container image building from the default branch #906

Merged
merged 5 commits into from
Dec 8, 2022

Conversation

pregnor
Copy link
Member

@pregnor pregnor commented Dec 6, 2022

Q A
Bug fix? no
New feature? no
API breaks? no
Deprecations? no
Related tickets -
License Apache 2.0

What's in this PR?

Added a GHA workflow for building Koperator performance test load container image from master builds and related tag builds - if we would use them in the future.
The package is available here.

Why?

To be able to reference the built image publicly, the source Dockerfile is available in this repository.

Additional context

Haven't tested the image itself, only the build process.

Also the package enablement needed organization level access to packages before the repo would have been connected to the new package. I'm now administrator of the new package, but I'm still not an organization admin.

Checklist

  • Implementation tested
  • Error handling code meets the guideline
  • Logging code meets the guideline
  • User guide and development docs updated (if needed)

@pregnor pregnor added the enhancement New feature or request label Dec 6, 2022
@pregnor pregnor requested a review from a team as a code owner December 6, 2022 12:56
@pregnor pregnor self-assigned this Dec 6, 2022
Kuvesz
Kuvesz previously approved these changes Dec 6, 2022
Copy link
Contributor

@Kuvesz Kuvesz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pregnor pregnor requested a review from a team December 6, 2022 13:25
bartam1
bartam1 previously approved these changes Dec 6, 2022
Copy link
Contributor

@bartam1 bartam1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont have much experience with github workflows but LGTM.

@pregnor pregnor dismissed stale reviews from bartam1 and Kuvesz via ca70e35 December 6, 2022 15:11
@pregnor pregnor force-pushed the ci/add-docker-perf-test-load-image branch from d4b6b6e to ca70e35 Compare December 6, 2022 15:11
@pregnor pregnor requested review from bartam1, Kuvesz and a team December 6, 2022 15:12
@pregnor pregnor merged commit 62aa764 into master Dec 8, 2022
@pregnor pregnor deleted the ci/add-docker-perf-test-load-image branch December 8, 2022 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants