Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Ginkgo from v1 to v2 #890

Merged
merged 3 commits into from
Nov 15, 2022
Merged

Update Ginkgo from v1 to v2 #890

merged 3 commits into from
Nov 15, 2022

Conversation

bartam1
Copy link
Contributor

@bartam1 bartam1 commented Nov 15, 2022

Q A
Bug fix? no
New feature? no
API breaks? no
Deprecations? yes
License Apache 2.0

What's in this PR?

Updates ginkgo test framework from v1 to v2
Refactor CC tasks

Why?

Ginkgo v1 is deprecated

Checklist

  • Implementation tested
  • Error handling code meets the guideline
  • Logging code meets the guideline
  • User guide and development docs updated (if needed)

@bartam1 bartam1 requested a review from a team as a code owner November 15, 2022 09:27
pregnor
pregnor approved these changes Nov 15, 2022
View reviewed changes
Copy link
Member

@pregnor pregnor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the questions LGTM, make sure to run the tests manually before merging.

@bartam1 bartam1 merged commit e8d39bc into master Nov 15, 2022
@bartam1 bartam1 deleted the refact_cco_test branch November 15, 2022 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pregnor pregnor pregnor approved these changes

@hi-im-aren hi-im-aren hi-im-aren approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bartam1 @pregnor @hi-im-aren