Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CruiseControlOperation feature bundle #872

Merged
merged 3 commits into from
Oct 11, 2022
Merged

CruiseControlOperation feature bundle #872

merged 3 commits into from
Oct 11, 2022

Conversation

bartam1
Copy link
Contributor

@bartam1 bartam1 commented Oct 7, 2022

Q A
Bug fix? yes
New feature? yes
API breaks? no
Deprecations? no
License Apache 2.0

What's in this PR?

This contains the whole package regarding the Koperator new Cruise Control handling.

  • cruisecontroloperation_controller
  • cruisecontroloperation_ttl_controller
  • cruisecontroltask_controller
  • v1alpha1/CruiseControlOperation CR

Why?

To make the connection between the Cruise Control and Koperator closer and more stable

Checklist

  • Implementation tested
  • Error handling code meets the guideline
  • Logging code meets the guideline
  • User guide and development docs updated (if needed)

@bartam1 bartam1 requested a review from a team as a code owner October 7, 2022 10:48
pregnor
pregnor previously approved these changes Oct 7, 2022
View reviewed changes
Copy link
Member

@pregnor pregnor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I already reviewed it in parts, it looks okay as a whole too.

@bartam1 bartam1 requested review from panyuenlau and Kuvesz October 7, 2022 15:40
panyuenlau
panyuenlau approved these changes Oct 10, 2022
View reviewed changes
Copy link
Member

@panyuenlau panyuenlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seen most (of not all) of the changes in other PRs

@bartam1 bartam1 merged commit e807183 into master Oct 11, 2022
@bartam1 bartam1 deleted the cruisecontroloperation_bundle branch October 11, 2022 08:44
@panyuenlau panyuenlau mentioned this pull request Oct 12, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panyuenlau panyuenlau panyuenlau approved these changes

@pregnor pregnor pregnor approved these changes

@Kuvesz Kuvesz Awaiting requested review from Kuvesz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bartam1 @pregnor @panyuenlau