Support client IP filtering through loadBalancerSourceRanges in case istioingress #835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pregnor
previously approved these changes
Jul 15, 2022
Co-authored-by: Patrik Egyed <[email protected]>
Co-authored-by: Patrik Egyed <[email protected]>
pregnor
reviewed
Jul 15, 2022
pregnor
previously approved these changes
Jul 15, 2022
pregnor
approved these changes
Jul 15, 2022
bartam1
approved these changes
Jul 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Support client IP filtering through LoadBalancer by allowing users to specify the
loadBalancerSourceRangesfield for the corresponding Kubernetes service when Kafka external listeners useistioingressas ingress controller.Why?
koperatordoesn't support client IP filtering for Kafka external listeners when those are exposed throughistioingressingress controller. Currently this is only supported whenenvoyis used and ingress controller.Additional context
Checklist