Fix kafka broker pod label selector used when reconciling broker pod deletion #793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panyuenlau
approved these changes
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Remove the
client.HasLabelsfrom the used label selector to find kafka broker pods that belong to cluster during broker pod deletion reconciliation.The
client.MatchingLabels(kafka.LabelsForKafka(r.KafkaCluster.Name))label selector is enough to match broker pods that belong to a cluster in a given namespace.Why?
controller-runtimedoesn't support multiple label selector option to be specified for selecting pods. When multiple label selector option is used it doesn't return an error but rather silently uses only the last label selector option from the list. This resulted to select pods in the given namespace that havebrokerIdlabel regardless what Kafka cluster the pods belong to as the first optionclient.MatchingLabels(kafka.LabelsForKafka(r.KafkaCluster.Name))was ignored.Checklist