Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Cruise Control controller #749

Merged
merged 7 commits into from
Jan 24, 2022
Merged

refactor: Cruise Control controller #749

merged 7 commits into from
Jan 24, 2022

Conversation

chrisgacsal
Copy link
Contributor

@chrisgacsal chrisgacsal commented Jan 21, 2022 •
edited
Loading

Q A
Bug fix? yes
New feature? no
API breaks? no
Deprecations? no
Related tickets fixes #685, partially #740
License Apache 2.0

What's in this PR?

The Cruise Control controller got completely refactored by enhancing the reconcile logic and adopting the go-cruise-control library for interacting with Cruise Control.

Checklist

  • Implementation tested
  • Error handling code meets the guideline
  • Logging code meets the guideline
  • User guide and development docs updated (if needed)

@chrisgacsal chrisgacsal requested a review from a team as a code owner January 21, 2022 14:50
@chrisgacsal chrisgacsal self-assigned this Jan 21, 2022
@chrisgacsal chrisgacsal force-pushed the refactor-cc-integration branch 2 times, most recently from 8eb2f9a to 6d75035 Compare January 21, 2022 15:00
@chrisgacsal chrisgacsal requested a review from stoader January 21, 2022 15:18
@chrisgacsal chrisgacsal force-pushed the refactor-cc-integration branch from 6d75035 to 0c573ac Compare January 24, 2022 08:02
stoader
stoader reviewed Jan 24, 2022
View reviewed changes
@chrisgacsal
refactor: method for checking active states
793bb47 
* `IsActionRequired()` => `IsActive()`
* add comments to methods for `CruiseControlState` and
  `CruiseControlVolumeState` structs
adamantal
adamantal previously approved these changes Jan 24, 2022
View reviewed changes
Copy link
Contributor

@adamantal adamantal left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I found no major errors in the core logic, so just adding my two nits.

Thanks for working on this! Using the new CC client lib makes the code much nicer!

@chrisgacsal chrisgacsal requested a review from stoader January 24, 2022 16:08
adamantal
adamantal approved these changes Jan 24, 2022
View reviewed changes
Copy link
Contributor

@adamantal adamantal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

stoader
stoader approved these changes Jan 24, 2022
View reviewed changes
Copy link
Member

@stoader stoader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thx for work.

@chrisgacsal chrisgacsal merged commit 97bdc71 into master Jan 24, 2022
@chrisgacsal chrisgacsal deleted the refactor-cc-integration branch January 24, 2022 16:47
@Kuvesz Kuvesz mentioned this pull request Jan 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stoader stoader stoader approved these changes

@baluchicken baluchicken baluchicken approved these changes

@adamantal adamantal adamantal approved these changes

@hi-im-aren hi-im-aren Awaiting requested review from hi-im-aren

Assignees

@chrisgacsal chrisgacsal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Operator might stuck if CruiseControl crashes during downscale
4 participants
@chrisgacsal @stoader @baluchicken @adamantal