Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: export annotations #340

Merged
merged 1 commit into from
Feb 22, 2024
Merged

refactor: export annotations #340

merged 1 commit into from
Feb 22, 2024

Conversation

csatib02
Copy link
Member

@csatib02 csatib02 commented Feb 14, 2024

Overview

  • Exported all annotations to common.go.
  • Applied the changes to config.go.

Fixes #253

Notes for reviewer

  • After this is merged I will open a PR for vault-secrets-reloader to change the annotations there too.

@csatib02 csatib02 requested a review from a team as a code owner February 14, 2024 13:06
@csatib02 csatib02 requested review from ramizpolic and removed request for a team February 14, 2024 13:06
@github-actions github-actions bot added the size/M Denotes a PR that changes 100-499 lines label Feb 14, 2024
@csatib02 csatib02 changed the title Feat: export annotations feat: export annotations Feb 14, 2024
@csatib02 csatib02 changed the title feat: export annotations refactor: export annotations Feb 15, 2024
@ramizpolic ramizpolic merged commit 935255e into bank-vaults:main Feb 22, 2024
30 of 31 checks passed
@csatib02 csatib02 deleted the feat/export-annotations branch February 22, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 100-499 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Single source of truth for annotation names
2 participants