Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add concurrency protection to injector #33

Merged
merged 2 commits into from
Jun 20, 2023
Merged

Add concurrency protection to injector #33

merged 2 commits into from
Jun 20, 2023

Conversation

ramizpolic
Copy link
Member

@ramizpolic ramizpolic commented Jun 20, 2023

Overview

Resolves #32

Notes for reviewer

Adds RWMutex on maps to protect against concurrent map read/write ops.

Signed-off-by: Ramiz Polic <[email protected]>
@ramizpolic ramizpolic changed the title injector: add syncing logic Add concurrency protection to injector Jun 20, 2023
@ramizpolic ramizpolic self-assigned this Jun 20, 2023
@sagikazarmark
Copy link
Member

The linter points out a few potential cases where the lock might be copied.

@ramizpolic ramizpolic merged commit 77e636a into main Jun 20, 2023
@ramizpolic ramizpolic deleted the injector/race branch June 20, 2023 16:22
JonTheNiceGuy pushed a commit to JonTheNiceGuy/vault-secrets-webhook that referenced this pull request Sep 20, 2023
Add concurrency protection to injector
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add concurrency protection to injector
2 participants