fix: don't discard default transport settings when turning off TLS verification #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victor-tsykanov
requested review from
sagikazarmark
and removed request for
a team
…ation Signed-off-by: Tsykanov Viktor <[email protected]>
victor-tsykanov
force-pushed
the
fix-setting-tls-options
branch
from
b11b17f to
bbe230c
Compare
ramizpolic
approved these changes
Feb 9, 2024
|
Thanks for resolving this @victor-tsykanov, much appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes the problem of proxy settings being ignored when TLS verification is disabled.
When REGISTRY_SKIP_VERIFY is set, http.Transport options are being overwritten which discards proxy settings applied previously.
Fixes #85