fix: prevent recurring helm install/upgrade creating a loop deleting caBundle, when certManager is enabled #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…caBundle, when certManager is enabled Signed-off-by: Rafael da Fonseca <[email protected]>
akijakya
approved these changes
Jan 25, 2024
ramizpolic
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Whenever cert-manager is used to generate the certificate and set the caBundle in the webhook, on recurring executions of helm the caBundle is deleted, and later re-added.
This PR disables handling of the caBundle property of the webhook in case cert-manager is being used, to prevent this issue.